jenkins-bot has submitted this change and it was merged.
Change subject: Converted $.each() to plain for() loop in GuidGenerator
......................................................................
Converted $.each() to plain for() loop in GuidGenerator
$.each() on strings fails in jQuery 1.9.
Change-Id: I71a7a0d6a861da3a262c8b0485ad7c2e6bf857b7
(cherry picked from commit 6ab0fc3b55ad70a341f34a98cd3d6d1fd0a37461)
---
M lib/resources/wikibase.utilities/wikibase.utilities.GuidGenerator.js
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Aude: Looks good to me, approved
WikidataJenkins: Verified
jenkins-bot: Verified
diff --git
a/lib/resources/wikibase.utilities/wikibase.utilities.GuidGenerator.js
b/lib/resources/wikibase.utilities/wikibase.utilities.GuidGenerator.js
index fd1bdde..a4b5fec 100644
--- a/lib/resources/wikibase.utilities/wikibase.utilities.GuidGenerator.js
+++ b/lib/resources/wikibase.utilities/wikibase.utilities.GuidGenerator.js
@@ -50,10 +50,12 @@
template = 'xx-x-x-x-xxx',
guid = '';
- $.each( template, function( i, character ) {
+ for( var i = 0; i < template.length; i++ ) {
+ var character = template.charAt( i );
+
if ( character === '-' ) {
guid += '-';
- return true;
+ continue;
}
var hex;
@@ -70,8 +72,7 @@
}
guid += hex;
-
- } );
+ }
return guid;
}
--
To view, visit https://gerrit.wikimedia.org/r/134114
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71a7a0d6a861da3a262c8b0485ad7c2e6bf857b7
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.24-wmf4
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
