TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/134267
Change subject: Popups: The promise of the popups was not forwarding failures ...................................................................... Popups: The promise of the popups was not forwarding failures Change-Id: Icc1d5a175ccf9ef000dd198f999994917912de3f --- M resources/ext.popups.renderer.article.js 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups refs/changes/67/134267/1 diff --git a/resources/ext.popups.renderer.article.js b/resources/ext.popups.renderer.article.js index f68a959..d308bd7 100644 --- a/resources/ext.popups.renderer.article.js +++ b/resources/ext.popups.renderer.article.js @@ -52,6 +52,7 @@ titles: title } ); + mw.popups.render.currentRequest.fail( deferred.reject ); mw.popups.render.currentRequest.done( function ( re ) { mw.popups.render.currentRequest = undefined; @@ -60,7 +61,8 @@ !re.query.pages[ re.query.pageids[ 0 ] ].extract || re.query.pages[ re.query.pageids[ 0 ] ].extract === '' ) { - return false; + deferred.reject(); + return; } mw.popups.render.cache[ href ] = {}; -- To view, visit https://gerrit.wikimedia.org/r/134267 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icc1d5a175ccf9ef000dd198f999994917912de3f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: TheDJ <hartman.w...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits