Mwalker has submitted this change and it was merged. Change subject: Refactored post-IRL-code-review. ......................................................................
Refactored post-IRL-code-review. Several things have changed; there is now only one file for all javascript, external libs have been broken out into their own modules, ajax now loads data so it's fresh, and there is more commenting in the correct formats. New helper functions and general DRYing up. This code needs to be reviewed for style, consistency with other extensions, library security, and visual design integration (in progress). It has one glaring issue, which is its resource loading - please advise on this; I get inconsistent results with the module loading so everything doesn't always render. Thanks. Change-Id: Ie078317191313730cba1ab60c036b7ffb2d2cb1c --- M FundraisingChart.php M fr_chart_body.php R modules/ext.fundraisingChart.bootstrap/bootstrap.min.css R modules/ext.fundraisingChart.chartsjs/Chart.min.js R modules/ext.fundraisingChart.d3/d3.v3.min.js R modules/ext.fundraisingChart.datamaps/datamaps.world.js R modules/ext.fundraisingChart.topojson/topojson.js D resources/js/barChart.js M resources/js/chartFormatHelpers.js D resources/js/fr_chart.js D resources/js/jquery.flot.js D resources/js/lineChart.js D resources/js/mapChart.js D resources/js/moment.js D resources/js/moment.min.js D resources/js/pieChart.js D resources/js/underscore.min.js 17 files changed, 290 insertions(+), 5,914 deletions(-) Approvals: Adamw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/118616 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie078317191313730cba1ab60c036b7ffb2d2cb1c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/FundraisingChart Gerrit-Branch: master Gerrit-Owner: Ssmith <ssm...@wikimedia.org> Gerrit-Reviewer: Adamw <awi...@wikimedia.org> Gerrit-Reviewer: Mwalker <mwal...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
