Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/134527
Change subject: Distinguish between VisualEditor and SourceEditor in event
logging
......................................................................
Distinguish between VisualEditor and SourceEditor in event logging
Change-Id: I5a4efd9d49fa36a048e80205204187bbd5e3f5a8
---
M includes/MobileFrontend.hooks.php
M javascripts/modules/editor/EditorOverlay.js
M javascripts/modules/editor/VisualEditorOverlay.js
3 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/27/134527/1
diff --git a/includes/MobileFrontend.hooks.php
b/includes/MobileFrontend.hooks.php
index a421537..39410f3 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -772,7 +772,7 @@
),
'mobile.editing.schema' => array(
'schema' => 'MobileWebEditing',
- 'revision' => 7675117,
+ 'revision' => 8593886,
),
'schema.MobileWebCta' => array(
'schema' => 'MobileWebCta',
diff --git a/javascripts/modules/editor/EditorOverlay.js
b/javascripts/modules/editor/EditorOverlay.js
index 6ffb1a8..4ae268e 100644
--- a/javascripts/modules/editor/EditorOverlay.js
+++ b/javascripts/modules/editor/EditorOverlay.js
@@ -27,11 +27,13 @@
header: M.template.get(
'modules/editor/EditorOverlayHeader' ),
content: M.template.get( 'modules/editor/EditorOverlay'
)
},
+ editor: 'SourceEditor',
log: function( action, errorText ) {
var
data = {
action: action,
section: this.sectionId,
+ editor: this.editor,
funnel: this.funnel
};
if ( errorText ) {
diff --git a/javascripts/modules/editor/VisualEditorOverlay.js
b/javascripts/modules/editor/VisualEditorOverlay.js
index 02f8e98..cf931c8 100644
--- a/javascripts/modules/editor/VisualEditorOverlay.js
+++ b/javascripts/modules/editor/VisualEditorOverlay.js
@@ -13,6 +13,7 @@
header: M.template.get(
'modules/editor/VisualEditorOverlayHeader' ),
content: M.template.get(
'modules/editor/VisualEditorOverlay' )
},
+ editor: 'VisualEditor',
className: 'overlay editor-overlay editor-overlay-ve
border-box',
initialize: function( options ) {
var self = this;
--
To view, visit https://gerrit.wikimedia.org/r/134527
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a4efd9d49fa36a048e80205204187bbd5e3f5a8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
