Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/134644

Change subject: jobrunners: set nice to 19, not 20
......................................................................

jobrunners: set nice to 19, not 20

19 is the max. nice treats out-of-range values by picking the nearest value
that is in range, so this is purely academic, but still worth correcting imo.

Change-Id: If2529f8b77eaaad62f0223709abe0effee683ed4
---
M modules/mediawiki/templates/jobrunner/jobs-loop.sh.erb
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/44/134644/1

diff --git a/modules/mediawiki/templates/jobrunner/jobs-loop.sh.erb 
b/modules/mediawiki/templates/jobrunner/jobs-loop.sh.erb
index 76a9ae2..eb2e181 100755
--- a/modules/mediawiki/templates/jobrunner/jobs-loop.sh.erb
+++ b/modules/mediawiki/templates/jobrunner/jobs-loop.sh.erb
@@ -148,7 +148,7 @@
                                elif [ -n "$db" -a -n "$type" ]; then
                                        foundjobs=y
                                        echo "$db $type"
-                                       nice -n 20 timeout $maxrealtime php 
MWScript.php runJobs.php --wiki="$db" --procs="$forkcount" --type="$type" 
--maxtime=$hpmaxtime --memory-limit=$maxsubprocmemory &
+                                       nice -n 19 timeout $maxrealtime php 
MWScript.php runJobs.php --wiki="$db" --procs="$forkcount" --type="$type" 
--maxtime=$hpmaxtime --memory-limit=$maxsubprocmemory &
                                        # Do not spend too much time on 
prioritized jobs
                                        local timestamp=`date +%s` # UNIX 
timestamp
                                        if [ "$timestamp" -lt "$started" -o $(( 
timestamp-started )) -ge "$lpmaxdelay" ]; then
@@ -175,7 +175,7 @@
                                elif [ -n "$db" ]; then
                                        foundjobs=y
                                        echo "$db"
-                                       nice -n 20 timeout $maxrealtime php 
MWScript.php runJobs.php --wiki="$db" --procs="$forkcount" --maxtime=$lpmaxtime 
--memory-limit=$maxsubprocmemory &
+                                       nice -n 19 timeout $maxrealtime php 
MWScript.php runJobs.php --wiki="$db" --procs="$forkcount" --maxtime=$lpmaxtime 
--memory-limit=$maxsubprocmemory &
                                        # Do not spend too much time on 
unprioritized jobs
                                        local timestamp=`date +%s` # UNIX 
timestamp
                                        if [ "$timestamp" -lt "$started" -o $(( 
timestamp-started )) -ge "$hpmaxdelay" ]; then

-- 
To view, visit https://gerrit.wikimedia.org/r/134644
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If2529f8b77eaaad62f0223709abe0effee683ed4
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to