Prtksxna has submitted this change and it was merged. Change subject: Popups: Fix popups for extiw links ......................................................................
Popups: Fix popups for extiw links These links were not ignored due to a typo. This also threw an error, because these links produced query.interwiki and not in query.pages. Change-Id: I3b5c5b900209323e3e72b41e3b02e90f1f53b4eb --- M resources/ext.popups.core.js M resources/ext.popups.renderer.article.js 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Prtksxna: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/ext.popups.core.js b/resources/ext.popups.core.js index 5af44d8..a209cc2 100644 --- a/resources/ext.popups.core.js +++ b/resources/ext.popups.core.js @@ -29,7 +29,7 @@ * @property {Array} IGNORE_CLASSES */ mw.popups.IGNORE_CLASSES = [ - '.exitw', + '.extiw', '.image', '.new', '.internal' diff --git a/resources/ext.popups.renderer.article.js b/resources/ext.popups.renderer.article.js index 4638ca0..f68a959 100644 --- a/resources/ext.popups.renderer.article.js +++ b/resources/ext.popups.renderer.article.js @@ -56,6 +56,7 @@ mw.popups.render.currentRequest = undefined; if ( + !re.query.pages || !re.query.pages[ re.query.pageids[ 0 ] ].extract || re.query.pages[ re.query.pageids[ 0 ] ].extract === '' ) { -- To view, visit https://gerrit.wikimedia.org/r/134265 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b5c5b900209323e3e72b41e3b02e90f1f53b4eb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: TheDJ <hartman.w...@gmail.com> Gerrit-Reviewer: Prtksxna <psax...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits