jenkins-bot has submitted this change and it was merged. Change subject: wfDebugMem: Fix binary prefix and improve usability ......................................................................
wfDebugMem: Fix binary prefix and improve usability * Fix: wfDebugMem no longer reports kibibytes as kilobytes * Usability: wfDebugMem now uses unit symbols (e.g. KiB) Change-Id: I1ab8aa3ccdb0fdea307913ada4ed42964d7fe960 --- M includes/GlobalFunctions.php 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Parent5446: Looks good to me, but someone else must approve Nikerabbit: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php index 91724dd..d2c7542 100644 --- a/includes/GlobalFunctions.php +++ b/includes/GlobalFunctions.php @@ -1007,14 +1007,14 @@ /** * Send a line giving PHP memory usage. * - * @param bool $exact Print exact values instead of kilobytes (default: false) + * @param bool $exact Print exact byte values instead of kibibytes (default: false) */ function wfDebugMem( $exact = false ) { $mem = memory_get_usage(); if ( !$exact ) { - $mem = floor( $mem / 1024 ) . ' kilobytes'; + $mem = floor( $mem / 1024 ) . ' KiB'; } else { - $mem .= ' bytes'; + $mem .= ' B'; } wfDebug( "Memory usage: $mem\n" ); } -- To view, visit https://gerrit.wikimedia.org/r/134826 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ab8aa3ccdb0fdea307913ada4ed42964d7fe960 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Taueres <santoro....@gmail.com> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: IAlex <coderev...@emsenhuber.ch> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: Parent5446 <tylerro...@gmail.com> Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits