Brian Wolff has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/134869

Change subject: Do not include user column on Special:MyUploads
......................................................................

Do not include user column on Special:MyUploads

If Special:ListFiles is being filtered to show only a specific
user, then there's not much point showing which user uploaded
the image, as they are all uploaded by the same user.

Bug: 30627
Change-Id: Ibe1be82cb8f3354889051ef00f3c0b9f9ea5180e
---
M includes/specials/SpecialListfiles.php
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/69/134869/1

diff --git a/includes/specials/SpecialListfiles.php 
b/includes/specials/SpecialListfiles.php
index 6b54fe8..3715b8b 100644
--- a/includes/specials/SpecialListfiles.php
+++ b/includes/specials/SpecialListfiles.php
@@ -170,9 +170,14 @@
                                'img_name' => $this->msg( 'listfiles_name' 
)->text(),
                                'thumb' => $this->msg( 'listfiles_thumb' 
)->text(),
                                'img_size' => $this->msg( 'listfiles_size' 
)->text(),
-                               'img_user_text' => $this->msg( 'listfiles_user' 
)->text(),
-                               'img_description' => $this->msg( 
'listfiles_description' )->text(),
                        );
+                       if ( is_null( $this->mUserName ) ) {
+                               // Do not show username if filtering by username
+                               $this->mFieldNames['img_user_text'] = 
$this->msg( 'listfiles_user' )->text();
+                       }
+                       // img_description down here, in order so that its 
still after the username field.
+                       $this->mFieldNames['img_description'] = $this->msg( 
'listfiles_description' )->text();
+
                        if ( !$wgMiserMode && !$this->mShowAll ) {
                                $this->mFieldNames['count'] = $this->msg( 
'listfiles_count' )->text();
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/134869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe1be82cb8f3354889051ef00f3c0b9f9ea5180e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff <bawolff...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to