Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/134943
Change subject: Compute directionality for frame correctly ...................................................................... Compute directionality for frame correctly Use OO.ui.Element.getDir instead of looking for a dir attribute. Change-Id: I0e6003b19dea0cd25c069ecb726ad9d4c078ddcc --- M src/Frame.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/43/134943/1 diff --git a/src/Frame.js b/src/Frame.js index 798ef35..b9c9f4e 100644 --- a/src/Frame.js +++ b/src/Frame.js @@ -178,7 +178,7 @@ this.loading = true; // Figure out directionality: - this.dir = this.$element.closest( '[dir]' ).prop( 'dir' ) || 'ltr'; + this.dir = OO.ui.Element.getDir( this.$element ) || 'ltr'; // Initialize contents doc.open(); -- To view, visit https://gerrit.wikimedia.org/r/134943 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0e6003b19dea0cd25c069ecb726ad9d4c078ddcc Gerrit-PatchSet: 1 Gerrit-Project: oojs/ui Gerrit-Branch: master Gerrit-Owner: Esanders <esand...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits