[MediaWiki-commits] [Gerrit] Add createSurface to base target - change (VisualEditor/VisualEditor)

[Esanders (Code Review)]

Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/135012

Change subject: Add createSurface to base target
......................................................................

Add createSurface to base target

Also override in SA target to create Desktop/MobileTarget.

Use this method in SurfaceWidget to create the correct surface.
for the current target.

Change-Id: I555935d2a9991d9d5d65f42d876e4a693ab871ad
---
M modules/ve/init/sa/ve.init.sa.Target.js
M modules/ve/init/ve.init.Target.js
M modules/ve/ui/widgets/ve.ui.SurfaceWidget.js
3 files changed, 23 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/12/135012/1

diff --git a/modules/ve/init/sa/ve.init.sa.Target.js 
b/modules/ve/init/sa/ve.init.sa.Target.js
index 84b03d8..9482967 100644
--- a/modules/ve/init/sa/ve.init.sa.Target.js
+++ b/modules/ve/init/sa/ve.init.sa.Target.js
@@ -68,7 +68,7 @@
 
        // Properties
        this.setupDone = true;
-       this.surface = new this.surfaceClass( this.document );
+       this.surface = this.createSurface( this.document );
        this.$document = this.surface.$element.find( '.ve-ce-documentNode' );
        this.toolbar = new ve.ui.TargetToolbar( this, this.surface, { 'shadow': 
true } );
 
@@ -92,3 +92,10 @@
                target.emit( 'surfaceReady' );
        } );
 };
+
+/**
+ * @inheritdoc
+ */
+ve.init.Target.prototype.createSurface = function ( dmDoc, config ) {
+       return new this.surfaceClass( dmDoc, config );
+};
diff --git a/modules/ve/init/ve.init.Target.js 
b/modules/ve/init/ve.init.Target.js
index a1091d7..dec5d9b 100644
--- a/modules/ve/init/ve.init.Target.js
+++ b/modules/ve/init/ve.init.Target.js
@@ -162,3 +162,17 @@
        },
        'all': null
 };
+
+/* Methods */
+
+/**
+ * Create a surface.
+ *
+ * @method
+ * @param {ve.dm.Document} dmDoc Document model
+ * @param {Object} [config] Configuration options
+ * @returns {ve.ui.Surface}
+ */
+ve.init.Target.prototype.createSurface = function ( dmDoc, config ) {
+       return new ve.ui.DesktopSurface( dmDoc, config );
+};
diff --git a/modules/ve/ui/widgets/ve.ui.SurfaceWidget.js 
b/modules/ve/ui/widgets/ve.ui.SurfaceWidget.js
index 8f7a11a..4415bf0 100644
--- a/modules/ve/ui/widgets/ve.ui.SurfaceWidget.js
+++ b/modules/ve/ui/widgets/ve.ui.SurfaceWidget.js
@@ -27,7 +27,7 @@
        OO.ui.Widget.call( this, config );
 
        // Properties
-       this.surface = new ve.ui.DesktopSurface( doc, { '$': this.$ } );
+       this.surface = ve.init.target.createSurface( doc, { '$': this.$ } );
        this.toolbar = new ve.ui.Toolbar( this.surface, { '$': this.$ } );
 
        // Initialization

-- 
To view, visit https://gerrit.wikimedia.org/r/135012
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I555935d2a9991d9d5d65f42d876e4a693ab871ad
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits