jenkins-bot has submitted this change and it was merged. Change subject: Add missing @return tags ......................................................................
Add missing @return tags Change-Id: I397971a02aa247f51ff4ff4ada3e50d66783ec2e --- M client/includes/hooks/SpecialWatchlistQueryHandler.php M client/tests/phpunit/includes/recentchanges/ExternalChangeFactoryTest.php 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: WikidataJenkins: Verified Thiemo Mättig (WMDE): Looks good to me, approved jenkins-bot: Verified diff --git a/client/includes/hooks/SpecialWatchlistQueryHandler.php b/client/includes/hooks/SpecialWatchlistQueryHandler.php index 34e6316..65478b8 100644 --- a/client/includes/hooks/SpecialWatchlistQueryHandler.php +++ b/client/includes/hooks/SpecialWatchlistQueryHandler.php @@ -141,6 +141,7 @@ /** * @param WebRequest $request + * @return boolean */ private function isEnhancedChangesEnabled( WebRequest $request ) { return $request->getBool( 'enhanced', $this->user->getOption( 'usenewrc' ) ) === true; diff --git a/client/tests/phpunit/includes/recentchanges/ExternalChangeFactoryTest.php b/client/tests/phpunit/includes/recentchanges/ExternalChangeFactoryTest.php index 4e2b778..50ec02d 100644 --- a/client/tests/phpunit/includes/recentchanges/ExternalChangeFactoryTest.php +++ b/client/tests/phpunit/includes/recentchanges/ExternalChangeFactoryTest.php @@ -47,6 +47,7 @@ /** * @param boolean $bot + * @return RecentChange */ protected function getEditRecentChange( $bot ) { $recentChange = new RecentChange(); -- To view, visit https://gerrit.wikimedia.org/r/135039 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I397971a02aa247f51ff4ff4ada3e50d66783ec2e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits