[MediaWiki-commits] [Gerrit] Fix WikibaseClient::getClientSiteLinkLookup - change (mediawiki...Wikibase)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Fix WikibaseClient::getClientSiteLinkLookup
......................................................................


Fix WikibaseClient::getClientSiteLinkLookup

Change-Id: I5865cef061c99cda18c159fadbad44a140c88d0a
---
M client/includes/WikibaseClient.php
M client/tests/phpunit/includes/WikibaseClientTest.php
2 files changed, 7 insertions(+), 2 deletions(-)

Approvals:
  Aude: Looks good to me, approved
  WikidataJenkins: Verified
  jenkins-bot: Verified



diff --git a/client/includes/WikibaseClient.php 
b/client/includes/WikibaseClient.php
index 9abcf10..1371e2f 100644
--- a/client/includes/WikibaseClient.php
+++ b/client/includes/WikibaseClient.php
@@ -579,8 +579,8 @@
 
                        $this->clientSiteLinkLookup = new ClientSiteLinkLookup(
                                $settings->getSetting( 'siteGlobalID' ),
-                               $this->getEntityLookup(),
-                               $this->getStore()->getSiteLinkLookup()
+                               $this->getStore()->getSiteLinkTable(),
+                               $this->getEntityLookup()
                        );
                }
 
diff --git a/client/tests/phpunit/includes/WikibaseClientTest.php 
b/client/tests/phpunit/includes/WikibaseClientTest.php
index 7764fbf..4c39442 100644
--- a/client/tests/phpunit/includes/WikibaseClientTest.php
+++ b/client/tests/phpunit/includes/WikibaseClientTest.php
@@ -161,6 +161,11 @@
                $this->assertInstanceOf( 
'Wikibase\Lib\OutputFormatValueFormatterFactory', $returnValue );
        }
 
+       public function testGetClientSiteLinkLookupReturnType() {
+               $returnValue = 
$this->getDefaultInstance()->getClientSiteLinkLookup();
+               $this->assertInstanceOf( 
'Wikibase\Client\ClientSiteLinkLookup', $returnValue );
+       }
+
        public function testGetDefaultInstance() {
                $this->assertSame(
                        WikibaseClient::getDefaultInstance(),

-- 
To view, visit https://gerrit.wikimedia.org/r/135053
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5865cef061c99cda18c159fadbad44a140c88d0a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Bene <benestar.wikime...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits