Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/135282
Change subject: Fix broken @return documentation
......................................................................
Fix broken @return documentation
I found one of these in Wikibase and run a global search.
Change-Id: I76c1519a47d7222f136272c59ea454b650808a86
---
M includes/EditPage.php
M includes/WebRequest.php
M includes/api/ApiMain.php
M includes/utils/ZipDirectoryReader.php
4 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/82/135282/1
diff --git a/includes/EditPage.php b/includes/EditPage.php
index 7be6274..e6186c6 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -1254,7 +1254,7 @@
* @param array|bool $resultDetails
*
* @throws ErrorPageError
- * return bool false, if output is done, true if rest of the form
should be displayed
+ * @return bool false, if output is done, true if rest of the form
should be displayed
*/
private function handleStatus( Status $status, $resultDetails ) {
global $wgUser, $wgOut;
diff --git a/includes/WebRequest.php b/includes/WebRequest.php
index 391b49e..ecc2372 100644
--- a/includes/WebRequest.php
+++ b/includes/WebRequest.php
@@ -489,7 +489,7 @@
* @param float $default
* @return float
*/
- public function getFloat( $name, $default = 0 ) {
+ public function getFloat( $name, $default = 0.0 ) {
return floatval( $this->getVal( $name, $default ) );
}
diff --git a/includes/api/ApiMain.php b/includes/api/ApiMain.php
index ccf91dd..df56735 100644
--- a/includes/api/ApiMain.php
+++ b/includes/api/ApiMain.php
@@ -957,7 +957,7 @@
/**
* Encode a value in a format suitable for a space-separated log line.
* @param string $s
- * return string
+ * @return string
*/
protected function encodeRequestLogValue( $s ) {
static $table;
diff --git a/includes/utils/ZipDirectoryReader.php
b/includes/utils/ZipDirectoryReader.php
index 1419bbb..6be186f 100644
--- a/includes/utils/ZipDirectoryReader.php
+++ b/includes/utils/ZipDirectoryReader.php
@@ -546,6 +546,9 @@
* If there are not enough bytes in the file to satisfy the request, the
* return value will be truncated. If a request is made for a segment
beyond
* the end of the file, an empty string will be returned.
+ *
+ * @param int $segIndex
+ *
* @return string
*/
function getSegment( $segIndex ) {
--
To view, visit https://gerrit.wikimedia.org/r/135282
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I76c1519a47d7222f136272c59ea454b650808a86
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
