jenkins-bot has submitted this change and it was merged. Change subject: Close the tipsy tooltip when clicked on it ......................................................................
Close the tipsy tooltip when clicked on it We want to close tipsy when user clicks on itself, not on trigger. Bug: 65664 Change-Id: I0de52d3917a984e675e42b83b9f5b767bd7f2e4b --- M resources/js/ext.uls.interface.js 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Santhosh: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/js/ext.uls.interface.js b/resources/js/ext.uls.interface.js index aee6534..4ebc846 100644 --- a/resources/js/ext.uls.interface.js +++ b/resources/js/ext.uls.interface.js @@ -257,6 +257,11 @@ }, timeout ); } ); + // hide the tooltip when clicked on it + $( '.tipsy' ).on( 'click', function () { + hideTipsy(); + } ); + // Event handler for links in the tooltip. // It looks like the tipsy is always created from scratch so that // there wont be multiple event handlers bound to same click. @@ -296,11 +301,6 @@ if ( !$( '.uls-menu:visible' ).length ) { showTipsy( 3000 ); } - } ); - - // hide the tooltip when clicked on uls trigger - $ulsTrigger.on( 'click', function () { - hideTipsy(); } ); } -- To view, visit https://gerrit.wikimedia.org/r/135010 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0de52d3917a984e675e42b83b9f5b767bd7f2e4b Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.wel...@t-online.de> Gerrit-Reviewer: Alolita <alolita.sha...@gmail.com> Gerrit-Reviewer: Amire80 <amir.ahar...@mail.huji.ac.il> Gerrit-Reviewer: Arrbee <run...@gmail.com> Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.wel...@t-online.de> Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits