jenkins-bot has submitted this change and it was merged.

Change subject: Loading toggling css with JavaScript
......................................................................


Loading toggling css with JavaScript

Not sure why it is loaded with rest - none of the rules work without
JavaScript any way.

Also fixes bug: 65503 as a side effect (since the client-js class
gets added before the toggle.js code and the .icon class)

Change-Id: I3d94db3f748426fd98871615edd004d40f71b24f
---
M includes/Resources.php
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  JGonera: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Resources.php b/includes/Resources.php
index 2a0e5a3..981b0e3 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -133,7 +133,6 @@
                        'less/common/footer.less',
                        'less/common/common.less',
                        'less/common/icons.less',
-                       'less/modules/toggle.less',
                ),
                'position' => 'top',
        ),
@@ -780,6 +779,9 @@
                'dependencies' => array(
                        'mobile.startup',
                ),
+               'styles' => array(
+                       'less/modules/toggle.less',
+               ),
                'scripts' => array(
                        'javascripts/modules/toggling/toggle.js',
                ),

-- 
To view, visit https://gerrit.wikimedia.org/r/135056
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3d94db3f748426fd98871615edd004d40f71b24f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Awjrichards <aricha...@wikimedia.org>
Gerrit-Reviewer: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to