jenkins-bot has submitted this change and it was merged.

Change subject: Adding header to top of citation pop-up list in mobile view
......................................................................


Adding header to top of citation pop-up list in mobile view

Per https://trello.com/c/xCo6uLAZ/9-5-references-dropdown-from-toolbar-styling

Also adding down-arrow indicator next to icon in handler (per Kaity)

Change-Id: I637891232f40ad217b4d3bd62bbecc502bf4cefb
Dependency: Id54100c55b05bdae5858ca72e4fd4418ceff0454
---
M modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js 
b/modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js
index 4dee4d2..e4f3670 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js
@@ -46,6 +46,8 @@
        { 'include': [ 'link' ] },
        // Cite
        {
+               'header': OO.ui.deferMsg( 'visualeditor-toolbar-cite-label' ),
+               'indicator': 'down',
                'type': 'list',
                'icon': 'reference',
                'title': OO.ui.deferMsg( 'visualeditor-toolbar-cite-label' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/134240
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I637891232f40ad217b4d3bd62bbecc502bf4cefb
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Kaldari <rkald...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Kaldari <rkald...@wikimedia.org>
Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to