Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/135742
Change subject: Return early when parsoid response is failure
......................................................................
Return early when parsoid response is failure
Not having this early return was causing the error:
"Cannot read property 'statusCode' of undefined"
Change-Id: I1d99521b93719ef9eeec6641dafa4fba46aa87ab
---
M pageloader/PageLoader.js
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/cxserver
refs/changes/42/135742/1
diff --git a/pageloader/PageLoader.js b/pageloader/PageLoader.js
index c4ed012..2bb0d11 100644
--- a/pageloader/PageLoader.js
+++ b/pageloader/PageLoader.js
@@ -42,9 +42,11 @@
function ( error, response, body ) {
if ( error ) {
deferred.reject( new Error( error ) );
+ return;
}
if ( response.statusCode !== 200 ) {
deferred.reject( new Error( 'Error while
fetching page: ' + response.statusCode ) );
+ return;
}
deferred.resolve( body );
}
--
To view, visit https://gerrit.wikimedia.org/r/135742
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d99521b93719ef9eeec6641dafa4fba46aa87ab
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/cxserver
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
