Mwalker has submitted this change and it was merged.
Change subject: Explicitly fail on required message fields
......................................................................
Explicitly fail on required message fields
Change-Id: I427a9d513ee48b83f84b95254d441ee78ca78cfd
---
M audit/paypal/SarFile.py
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Mwalker: Looks good to me, approved
jenkins-bot: Verified
diff --git a/audit/paypal/SarFile.py b/audit/paypal/SarFile.py
index 14c42eb..bb3ab79 100644
--- a/audit/paypal/SarFile.py
+++ b/audit/paypal/SarFile.py
@@ -26,6 +26,21 @@
ppreport.read(self.path, self.VERSION, self.parse_line)
def parse_line(self, row):
+ required_fields = [
+ "Period 3 Amount",
+ "Subscription Currency",
+ "Subscription ID",
+ "Subscription Payer Name",
+ "Subscription Period 3",
+ ]
+
+ missing_fields = []
+ for field in required_fields:
+ if not field in row or row[field] == '':
+ missing_fields.append(field)
+ if missing_fields:
+ raise RuntimeError("Message is missing some important fields:
[{fields}]".format(fields=", ".join(missing_fields)))
+
names = row['Subscription Payer Name'].split(' ')
out = {
--
To view, visit https://gerrit.wikimedia.org/r/135378
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I427a9d513ee48b83f84b95254d441ee78ca78cfd
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/tools
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Katie Horn <kh...@wikimedia.org>
Gerrit-Reviewer: Mwalker <mwal...@wikimedia.org>
Gerrit-Reviewer: Ssmith <ssm...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
