Mwalker has submitted this change and it was merged.

Change subject: Log incoming and normalized Amazon messages (take 2)
......................................................................


Log incoming and normalized Amazon messages (take 2)

Change-Id: I0331d7c54f5d81d5acba38df07ab2bf978563291
---
M Core/Logging/LogEvent.php
M PaymentProviders/Amazon/AmazonListener.php
2 files changed, 12 insertions(+), 1 deletion(-)

Approvals:
  Mwalker: Looks good to me, approved



diff --git a/Core/Logging/LogEvent.php b/Core/Logging/LogEvent.php
index beb6e44..f8c3047 100644
--- a/Core/Logging/LogEvent.php
+++ b/Core/Logging/LogEvent.php
@@ -101,4 +101,4 @@
                array_unshift( $stack, $descStr );
                return $stack;
        }
-}
\ No newline at end of file
+}
diff --git a/PaymentProviders/Amazon/AmazonListener.php 
b/PaymentProviders/Amazon/AmazonListener.php
index ab2aa3b..78da844 100644
--- a/PaymentProviders/Amazon/AmazonListener.php
+++ b/PaymentProviders/Amazon/AmazonListener.php
@@ -10,6 +10,8 @@
 
 /**
  * Dispatches incoming messages accoring to type
+ *
+ * @see 
https://amazonpayments.s3.amazonaws.com/FPS_ASP_Guides/ASP_Advanced_Users_Guide.pdf
  */
 class AmazonListener extends RestListener {
        protected $byTypes = array(
@@ -35,6 +37,10 @@
 
        protected function parseEnvelope( Request $request ) {
                $requestValues = $request->getValues();
+
+               $secureLog = Logger::getTaggedLogger( 'RawData' );
+               $secureLog->info( "Incoming message (raw)", $requestValues );
+
                $messages = array();
                if ( array_key_exists( 'notificationType', $requestValues ) ) {
                        $type = $requestValues['notificationType'];
@@ -42,6 +48,8 @@
                                $klass = $this->byType[$type];
                                $message = new $klass();
                                $message->constructFromValues($requestValues);
+
+                               $secureLog->debug( "Processed message 
(normalized)", $message );
 
                                $messages[] = $message;
                        } else {
@@ -53,6 +61,9 @@
                                $klass = $this->byStatus[$status];
                                $message = new $klass();
                                $message->constructFromValues($requestValues);
+
+                               $secureLog->debug( "Processed message 
(normalized)", $message );
+
                                $messages[] = $message;
                        } else {
                                Logger::info( "Message ignored: status = 
{$status}" );

-- 
To view, visit https://gerrit.wikimedia.org/r/135982
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0331d7c54f5d81d5acba38df07ab2bf978563291
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Mwalker <mwal...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to