[MediaWiki-commits] [Gerrit] Code tweaks to change handler test - change (mediawiki...Wikibase)

[Jeroen De Dauw (Code Review)]

Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/136032

Change subject: Code tweaks to change handler test
......................................................................

Code tweaks to change handler test

Change-Id: I6f03b861eff437df51bbadbaa281bf1205bd021c
---
M client/tests/phpunit/includes/ChangeHandlerTest.php
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/32/136032/1

diff --git a/client/tests/phpunit/includes/ChangeHandlerTest.php 
b/client/tests/phpunit/includes/ChangeHandlerTest.php
index 6ff8e32..e3d8755 100644
--- a/client/tests/phpunit/includes/ChangeHandlerTest.php
+++ b/client/tests/phpunit/includes/ChangeHandlerTest.php
@@ -3,6 +3,7 @@
 namespace Wikibase\Test;
 
 use Site;
+use Title;
 use Wikibase\Change;
 use Wikibase\ChangeHandler;
 use Wikibase\Client\WikibaseClient;
@@ -1135,9 +1136,9 @@
                }
        }
 
-       protected static function titles2strings( $titles ) {
+       private function titles2strings( array $titles ) {
                return array_map(
-                       function ( $title ) {
+                       function ( Title $title ) {
                                return $title->getPrefixedDBKey();
                        },
                        $titles
@@ -1151,7 +1152,7 @@
                $this->updateMockRepo( $entities );
 
                $toUpdate = $this->handler->getPagesToUpdate( $change );
-               $toUpdate = self::titles2strings( $toUpdate );
+               $toUpdate = $this->titles2strings( $toUpdate );
 
                $this->assertArrayEquals( $expected, $toUpdate );
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/136032
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f03b861eff437df51bbadbaa281bf1205bd021c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits