Hoo man has submitted this change and it was merged. Change subject: Remove unused referenced and stop using deprecated aliases ......................................................................
Remove unused referenced and stop using deprecated aliases Change-Id: I7d3693fa2adb4a59f9da3907d2bfa81802969760 --- M client/tests/phpunit/includes/ChangeHandlerTest.php M client/tests/phpunit/includes/hooks/LanguageLinkBadgeDisplayTest.php M client/tests/phpunit/includes/scribunto/WikibaseLuaIntegrationTestItemSetUpHelper.php 3 files changed, 4 insertions(+), 8 deletions(-) Approvals: Hoo man: Looks good to me, approved WikidataJenkins: Verified diff --git a/client/tests/phpunit/includes/ChangeHandlerTest.php b/client/tests/phpunit/includes/ChangeHandlerTest.php index 11be20f..c4d0039 100644 --- a/client/tests/phpunit/includes/ChangeHandlerTest.php +++ b/client/tests/phpunit/includes/ChangeHandlerTest.php @@ -7,12 +7,11 @@ use Wikibase\Change; use Wikibase\ChangeHandler; use Wikibase\Client\WikibaseClient; -use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\ItemId; -use Wikibase\DataModel\SimpleSiteLink; +use Wikibase\DataModel\SiteLink; use Wikibase\EntityChange; -use Wikibase\EntityDiff; -use Wikibase\Item; +use Wikibase\DataModel\Entity\EntityDiff; +use Wikibase\DataModel\Entity\Item; use Wikibase\ItemUsageIndex; /** @@ -30,7 +29,6 @@ * @author Jeroen De Dauw < jeroended...@gmail.com > */ class ChangeHandlerTest extends \MediaWikiTestCase { - /** @var MockRepository $repo */ protected static $repo; @@ -1126,7 +1124,7 @@ $siteIdentifier = $siteId; } - $entity->addSiteLink( new SimpleSiteLink( $siteIdentifier, $page ) ); + $entity->addSiteLink( new SiteLink( $siteIdentifier, $page ) ); } } else { $entity = $siteLinks; diff --git a/client/tests/phpunit/includes/hooks/LanguageLinkBadgeDisplayTest.php b/client/tests/phpunit/includes/hooks/LanguageLinkBadgeDisplayTest.php index 691b1a4..b222264 100644 --- a/client/tests/phpunit/includes/hooks/LanguageLinkBadgeDisplayTest.php +++ b/client/tests/phpunit/includes/hooks/LanguageLinkBadgeDisplayTest.php @@ -4,7 +4,6 @@ use Wikibase\Client\Hooks\LanguageLinkBadgeDisplay; use Wikibase\Client\ClientSiteLinkLookup; -use Wikibase\DataModel\SiteLink; use Wikibase\DataModel\Entity\Item; use Language; use Title; diff --git a/client/tests/phpunit/includes/scribunto/WikibaseLuaIntegrationTestItemSetUpHelper.php b/client/tests/phpunit/includes/scribunto/WikibaseLuaIntegrationTestItemSetUpHelper.php index e7b5817..bc40c84 100644 --- a/client/tests/phpunit/includes/scribunto/WikibaseLuaIntegrationTestItemSetUpHelper.php +++ b/client/tests/phpunit/includes/scribunto/WikibaseLuaIntegrationTestItemSetUpHelper.php @@ -12,7 +12,6 @@ use Wikibase\DataModel\Entity\PropertyId; use Wikibase\DataModel\SiteLink; use Wikibase\DataModel\Snak\Snak; -use Wikibase\Lib\V4GuidGenerator; use Wikibase\SnakFactory; use Wikibase\Test\MockClientStore; use Wikibase\Test\MockRepository; -- To view, visit https://gerrit.wikimedia.org/r/136930 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d3693fa2adb4a59f9da3907d2bfa81802969760 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Hoo man <h...@online.de> Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits