Daniel Werner has uploaded a new change for review. Change subject: Refactored some of the EditableValue tests. ......................................................................
Refactored some of the EditableValue tests. Tests do not execute assertions in startup and tear down anymore now. Added a generic function to fabricate new EditableValue instances. Upon this change we could refactor tests for other EditableValue types to use this common base and always execute these basic tests instead of only testing functionality which is specific to the inherited EditableValue type (which is what we are doing right now). There are still 17 failing tests, these will be fixed as a follow up. Change-Id: Ia2791687772bdb64f6f9b8586b13855859104361 --- M repo/tests/qunit/wikibase.ui.PropertyEditTool.EditableValue.tests.js 1 file changed, 235 insertions(+), 191 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/67/26967/1 -- To view, visit https://gerrit.wikimedia.org/r/26967 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia2791687772bdb64f6f9b8586b13855859104361 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
