Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/137719
Change subject: Do not wrap <table> inside <p> on Special:UserRights
......................................................................
Do not wrap <table> inside <p> on Special:UserRights
Special:UserRights has a table inside a paragraph which is invalid html.
The validator will except the open <p> but than gives a error on the
closing </p>: "No p element in scope but a p end tag seen."
IE11 also gives a hint on the console (hint HTML1509).
Fixed this by just removing the paragraph.
Change-Id: Ie17725d0b8018853e445142fa9c436db5471dcc6
---
M includes/specials/SpecialUserrights.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/19/137719/1
diff --git a/includes/specials/SpecialUserrights.php
b/includes/specials/SpecialUserrights.php
index 8a5ba1d..411970e 100644
--- a/includes/specials/SpecialUserrights.php
+++ b/includes/specials/SpecialUserrights.php
@@ -547,7 +547,7 @@
->rawParams( $userToolLinks )->parse() .
$this->msg( 'userrights-groups-help', $user->getName()
)->parse() .
$grouplist .
- Xml::tags( 'p', null, $this->groupCheckboxes( $groups,
$user ) ) .
+ $this->groupCheckboxes( $groups, $user ) .
Xml::openElement( 'table', array( 'id' =>
'mw-userrights-table-outer' ) ) .
"<tr>
<td class='mw-label'>" .
--
To view, visit https://gerrit.wikimedia.org/r/137719
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie17725d0b8018853e445142fa9c436db5471dcc6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
