Hoo man has submitted this change and it was merged.
Change subject: Repeat ItemContent removal in ChangeOpQualifierRemoveTest
......................................................................
Repeat ItemContent removal in ChangeOpQualifierRemoveTest
Change-Id: I4878ff25673e51b2a72a7c6987b98d5fa1b8387a
---
M repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php
1 file changed, 12 insertions(+), 8 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
WikidataJenkins: Verified
diff --git
a/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php
index 571cd07..4f6fd94 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php
@@ -8,8 +8,9 @@
use Wikibase\DataModel\Claim\Claim;
use Wikibase\DataModel\Claim\Claims;
use Wikibase\DataModel\Entity\Entity;
+use Wikibase\DataModel\Entity\Item;
+use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Snak\PropertyValueSnak;
-use Wikibase\ItemContent;
/**
* @covers Wikibase\ChangeOp\ChangeOpQualifierRemove
@@ -43,7 +44,7 @@
$snak = new PropertyValueSnak( 2754236, new StringValue( 'test'
) );
$args = array();
- $item = $this->provideNewItemWithClaim( 'q345', $snak );
+ $item = $this->newItemWithClaim( 'q345', $snak );
$claims = $item->getClaims();
/** @var Claim $claim */
$claim = reset( $claims );
@@ -76,14 +77,17 @@
$this->assertFalse( $qualifiers->hasSnakHash( $snakHash ),
"Qualifier still exists" );
}
- protected function provideNewItemWithClaim( $itemId, $snak ) {
- $entity = ItemContent::newFromArray( array( 'entity' => $itemId
) )->getEntity();
- $claim = $entity->newClaim( $snak );
- $claim->setGuid( $entity->getId()->getPrefixedId() .
'$D8404CDA-25E4-4334-AG03-A3290BCD9CQP' );
+ private function newItemWithClaim( $itemIdString, $snak ) {
+ $item = Item::newEmpty();
+ $item->setId( new ItemId( $itemIdString ) );
+
+ $claim = $item->newClaim( $snak );
+ $claim->setGuid( $itemIdString .
'$D8404CDA-25E4-4334-AG03-A3290BCD9CQP' );
$claims = new Claims();
$claims->addClaim( $claim );
- $entity->setClaims( $claims );
- return $entity;
+ $item->setClaims( $claims );
+
+ return $item;
}
}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/137871
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4878ff25673e51b2a72a7c6987b98d5fa1b8387a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
