[MediaWiki-commits] [Gerrit] animation: Use the animation mixin in core and pass fill-mod... - change (mediawiki...Popups)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: animation: Use the animation mixin in core and pass fill-mode 
as an argument
......................................................................


animation: Use the animation mixin in core and pass fill-mode as an argument

Bug: 65923
Change-Id: I4222d811d56a84fe046dfe4a96eda636e76967a5
---
M resources/ext.popups.animation.less
1 file changed, 6 insertions(+), 18 deletions(-)

Approvals:
  Phuedx: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/ext.popups.animation.less 
b/resources/ext.popups.animation.less
index f159833..879b432 100644
--- a/resources/ext.popups.animation.less
+++ b/resources/ext.popups.animation.less
@@ -1,23 +1,11 @@
+@import "mediawiki.mixins.animation";
+
 .mwe-popups-translate(@x, @y) {
        -webkit-transform: translate(@x, @y);
        -moz-transform: translate(@x, @y);
        -ms-transform: translate(@x, @y);
        -o-transform: translate(@x, @y);
        transform: translate(@x, @y);
-}
-
-.mwe-popups-animation(...) {
-       -webkit-animation: @arguments;
-       -moz-animation: @arguments;
-       -o-animation: @arguments;
-       animation: @arguments;
-
-       /* Leave the element in its final animation state */
-       -webkit-animation-fill-mode: forwards; /* Chrome 16+, Safari 4+ */
-       -moz-animation-fill-mode: forwards; /* FF 5+ */
-       -o-animation-fill-mode: forwards; /* not implemented yet */
-       -ms-animation-fill-mode: forwards; /* IE 10+ */
-       animation-fill-mode: forwards; /* when the spec is finished */
 }
 
 /* FIXME: Use Phuedx's approach to make this cleaner
@@ -135,17 +123,17 @@
 }
 
 .mwe-popups-fade-in-up {
-       .mwe-popups-animation(mwe-popups-fade-in-up, 0.3s);
+       .animation(mwe-popups-fade-in-up, 0.3s, ease, forwards);
 }
 
 .mwe-popups-fade-in-down {
-       .mwe-popups-animation(mwe-popups-fade-in-down, 0.3s);
+       .animation(mwe-popups-fade-in-down, 0.3s, ease, forwards);
 }
 
 .mwe-popups-fade-out-down {
-       .mwe-popups-animation(mwe-popups-fade-out-down, 0.15s);
+       .animation(mwe-popups-fade-out-down, 0.15s, ease, forwards);
 }
 
 .mwe-popups-fade-out-up {
-       .mwe-popups-animation(mwe-popups-fade-out-up, 0.15s);
+       .animation(mwe-popups-fade-out-up, 0.15s, ease, forwards);
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/136975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4222d811d56a84fe046dfe4a96eda636e76967a5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <psax...@wikimedia.org>
Gerrit-Reviewer: Phuedx <g...@samsmith.io>
Gerrit-Reviewer: Spage <sp...@wikimedia.org>
Gerrit-Reviewer: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits