Matmarex has uploaded a new change for review. Change subject: Display language links in sidebar ucfirst using CSS ......................................................................
Display language links in sidebar ucfirst using CSS Previously they were displayed this way by simply modifying the text to be uppercase in SkinTemplate. This has a couple of bad side-effects, including losing the information about correct capitalisation and forcing the capitalized name on every user of standard SkinTemplate functions (some skins, like CologneBlue, do use the standard functions to retrieve this link, but display them in a different menu, e.g. horizontally). In the CSS, we use :first-letter and text-transform:uppercase. This is different from text-transform:capitalize, as the latter ucfirsts every word in the sentence, not just the first one. Both ways work even on IE6. The styles are added to commonInterface.css, since we want this to apply to all skins using standard sidebar, not only the ones included with core - just like the ucfirsting in SkinTemplate did. Unfortunately some skins do not include it - I assumed there is a good reason for this and duplicated the code in per-skin CSS. Effectively, the new styles apply to all skins except Nostalgia, Standard and CologneBlue (since these do not display interwikis in the sidebar) and MySkin (since it's supposed to be a "blank slate" skin). Related bug: bug 37705. This reverts three commits (one partially): * I623cf070, the original broken fix for bug 37705 * I91d50515, my attempt to make the situation slightly less bad * I8b56ccb6 (partially), usage of the above half-fix in CologneBlue Change-Id: I87cbfb3f7f8ce0037585c0396647216e3edcfa27 --- M includes/SkinTemplate.php M skins/CologneBlue.php M skins/chick/main.css M skins/common/commonInterface.css M skins/modern/main.css M skins/simple/main.css 6 files changed, 22 insertions(+), 28 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/39/27039/1 -- To view, visit https://gerrit.wikimedia.org/r/27039 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I87cbfb3f7f8ce0037585c0396647216e3edcfa27 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex <matma....@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
