Dbrant has submitted this change and it was merged.
Change subject: Revert "Honor system font size setting in WebView"
......................................................................
Revert "Honor system font size setting in WebView"
This reverts commit ad4d74ce79dbfe29eb32b2205c71d5d256c2287c.
Change-Id: Ic7f1c3e9257af1bcd13485c94efbe57cd8a9e8b2
---
M wikipedia/res/values/dimens.xml
M wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
2 files changed, 0 insertions(+), 8 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
diff --git a/wikipedia/res/values/dimens.xml b/wikipedia/res/values/dimens.xml
index 7bce777..a6dd140 100644
--- a/wikipedia/res/values/dimens.xml
+++ b/wikipedia/res/values/dimens.xml
@@ -4,7 +4,4 @@
<dimen name="activity_horizontal_margin">16dp</dimen>
<dimen name="activity_vertical_margin">16dp</dimen>
- <!-- Default font size for WebView text based on system settings -->
- <dimen name="textSize">8sp</dimen>
-
</resources>
\ No newline at end of file
diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
index 2bed615..a3df5a3 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
@@ -1,7 +1,6 @@
package org.wikipedia.page;
import android.content.Intent;
-import android.content.res.Resources;
import android.os.Build;
import android.os.Bundle;
import android.support.v4.app.Fragment;
@@ -271,10 +270,6 @@
// disable TOC drawer until the page is loaded
tocDrawer.setSlidingEnabled(false);
searchArticlesFragment.setTocEnabled(false);
-
- // Adjust font size based on system settings
- float fontSize = getResources().getDimension(R.dimen.textSize);
- webView.getSettings().setDefaultFontSize((int) fontSize);
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) {
// Enable Pinch-Zoom
--
To view, visit https://gerrit.wikimedia.org/r/138372
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7f1c3e9257af1bcd13485c94efbe57cd8a9e8b2
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
