Hoo man has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/138591

Change subject: Reset the wb_entity_per_page table in 
PropertyInfoTableBuilderTest
......................................................................

Reset the wb_entity_per_page table in PropertyInfoTableBuilderTest

Prior to adding our test data.

Bug: 66405
Change-Id: I91efdc6f6218639b8c5d5ea1e191a3062a316b57
---
M repo/tests/phpunit/includes/store/sql/PropertyInfoTableBuilderTest.php
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/91/138591/1

diff --git 
a/repo/tests/phpunit/includes/store/sql/PropertyInfoTableBuilderTest.php 
b/repo/tests/phpunit/includes/store/sql/PropertyInfoTableBuilderTest.php
index ffbdc76..858e9ea 100644
--- a/repo/tests/phpunit/includes/store/sql/PropertyInfoTableBuilderTest.php
+++ b/repo/tests/phpunit/includes/store/sql/PropertyInfoTableBuilderTest.php
@@ -8,7 +8,6 @@
 use Wikibase\PropertyInfoTable;
 use Wikibase\PropertyInfoTableBuilder;
 use Wikibase\Repo\WikibaseRepo;
-use Wikibase\Lib\Store\WikiPageEntityLookup;
 
 /**
  * @covers Wikibase\PropertyInfoTableBuilder
@@ -52,6 +51,12 @@
        }
 
        public function testRebuildPropertyInfo() {
+               $table = new PropertyInfoTable( false );
+
+               // Reset the epp table
+               $dbw = $table->getWriteConnection();
+               $dbw->delete( 'wb_entity_per_page',  '*' );
+
                $properties = $this->initProperties();
                $propertyIds = array_keys( $properties );
 
@@ -59,7 +64,6 @@
                //       so we should also use the EntityLookup from 
WikibaseRepo.
                $entityLookup = 
WikibaseRepo::getDefaultInstance()->getEntityLookup();
 
-               $table = new PropertyInfoTable( false );
                $builder = new PropertyInfoTableBuilder( $table, $entityLookup 
);
                $builder->setBatchSize( 3 );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/138591
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I91efdc6f6218639b8c5d5ea1e191a3062a316b57
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to