Rohan013 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/138609

Change subject: Fix for Bug 63980 - Comparison of limits in pingLimiter is 
incorrect
......................................................................

Fix for Bug 63980 - Comparison of limits in pingLimiter is incorrect

Change-Id: Ie9da2c5af82d60e974bd258554b9438c1667630a
---
M includes/User.php
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/09/138609/1

diff --git a/includes/User.php b/includes/User.php
index f2d3d9b..526653b 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -1719,7 +1719,9 @@
                // If more than one group applies, use the group with the 
highest limit
                foreach ( $this->getGroups() as $group ) {
                        if ( isset( $limits[$group] ) ) {
-                               if ( $userLimit === false || $limits[$group] > 
$userLimit ) {
+                               if ( $userLimit === false
+                                       || $limits[$group][0] / 
$limits[$group][1] > $userLimit[0] / $userLimit[1]
+                               ) {
                                        $userLimit = $limits[$group];
                                }
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/138609
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9da2c5af82d60e974bd258554b9438c1667630a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Rohan013 <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to