Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/138619
Change subject: Remove dead calls to autocomplete
......................................................................
Remove dead calls to autocomplete
We are not using autocomplete anymore, so calls to it just do nothing
(in jQuery UI 1.8) or fail loudly (in jQuery UI 1.9).
Change-Id: I9bfbfcb8c78a2759b08a761bf66ca981a25621aa
---
M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SiteIdInterface.js
M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SitePageInterface.js
2 files changed, 2 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/19/138619/1
diff --git
a/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SiteIdInterface.js
b/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SiteIdInterface.js
index 4872eb4..f19e78e 100644
---
a/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SiteIdInterface.js
+++
b/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SiteIdInterface.js
@@ -290,10 +290,9 @@
var success = PARENT.prototype._setState.call( this, state );
if( this._inputElem !== null ) {
if( state === this.STATE.DISABLED ) {
- this._inputElem.autocomplete( 'disable' );
- this._inputElem.autocomplete( 'close' );
+ this._inputElem.data( 'siteselector'
).disable();
} else {
- this._inputElem.autocomplete( 'enable' );
+ this._inputElem.data( 'siteselector' ).enable();
}
}
return success;
diff --git
a/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SitePageInterface.js
b/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SitePageInterface.js
index c0be003..993ec77 100644
---
a/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SitePageInterface.js
+++
b/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SitePageInterface.js
@@ -149,15 +149,6 @@
this._site = site;
this._currentResults = []; // empty current suggestions...
- if( this.isInEditMode() ) {
- this._inputElem.autocomplete( 'search' ); // ...and get
new suggestions
-
- /* // TODO: this should be done after "search" is
finished, apparently, there is no callback for that currently...
- if( ! this.isValid() ) {
- this.setValue( '' );
- }
- */
- }
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/138619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9bfbfcb8c78a2759b08a761bf66ca981a25621aa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
