jenkins-bot has submitted this change and it was merged. Change subject: Fix accessibility issue for search fragment buttons ......................................................................
Fix accessibility issue for search fragment buttons ToC and overflow menu didn't have any contentDescription, so TalkBack could not pick up the meaning for them. This helps visually impaired people to better use our app. https://ticket.wikimedia.org/otrs/index.pl?Action=AgentZoom&TicketID=7609290 Change-Id: I8f1cac67e98d3cf0255da92c23af75f0c6b1cfdf --- M wikipedia/res/layout/fragment_search.xml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Yuvipanda: Looks good to me, approved jenkins-bot: Verified diff --git a/wikipedia/res/layout/fragment_search.xml b/wikipedia/res/layout/fragment_search.xml index f7792fd..51298b3 100644 --- a/wikipedia/res/layout/fragment_search.xml +++ b/wikipedia/res/layout/fragment_search.xml @@ -78,6 +78,7 @@ android:layout_height="48dp" android:src="@drawable/ic_toc" android:background="@drawable/search_item_background" + android:contentDescription="@string/menu_show_toc" /> <ImageView android:id="@+id/search_bar_show_menu" @@ -86,6 +87,7 @@ android:padding="8dp" android:src="@drawable/ic_menu_moreoverflow_normal_holo_light" android:background="@drawable/search_item_background" + android:contentDescription="@string/abc_action_menu_overflow_description" /> </LinearLayout> <!-- Android has no easy way to give us a light border --> -- To view, visit https://gerrit.wikimedia.org/r/140055 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f1cac67e98d3cf0255da92c23af75f0c6b1cfdf Gerrit-PatchSet: 2 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: BearND <bsitzm...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: Yuvipanda <yuvipa...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
