Daniel Werner has uploaded a new change for review. Change subject: Further re-factored PropertyEditTool tests ......................................................................
Further re-factored PropertyEditTool tests * Introduced a factory for creating new test PropertyEditTool instances, startup is no longer abused to create three instances. * Added a function for the test addValueToPET() to add values to the PropertyEditTool. See the todo though. * Corrected logic of PropertyEditTool.isFull() in case multiple values were not allowed. Change-Id: If7fff87b416cf91b08e4557a88b5b3d50caa0add --- M repo/resources/wikibase.ui.PropertyEditTool.js M repo/tests/qunit/wikibase.ui.PropertyEditTool.tests.js 2 files changed, 155 insertions(+), 108 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/56/27356/1 -- To view, visit https://gerrit.wikimedia.org/r/27356 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If7fff87b416cf91b08e4557a88b5b3d50caa0add Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
