Chad has submitted this change and it was merged.
Change subject: Nostalgia.php cleanup
......................................................................
Nostalgia.php cleanup
* Updated documentation
* Removed pointless $dir = __DIR__
* Removed pointless defined( 'MEDIAWIKI' ) check
Change-Id: Id42c41edd3cab72f6301a1c5d632aa9b4e1acef3
---
M Nostalgia.php
1 file changed, 8 insertions(+), 14 deletions(-)
Approvals:
Chad: Verified; Looks good to me, approved
diff --git a/Nostalgia.php b/Nostalgia.php
index 47df92d..7e04bf4 100644
--- a/Nostalgia.php
+++ b/Nostalgia.php
@@ -1,26 +1,20 @@
<?php
/**
- * Extension to provide the ancient nostalgia skin, plus SkinLegacy support
+ * The ancient Nostalgia skin, plus SkinLegacy support.
*/
-if( !defined( 'MEDIAWIKI' ) ) {
- die( -1 );
-}
-
$wgExtensionCredits['skin'][] = array(
- 'path' => __FILE__,
- 'name' => 'Nostalgia',
+ 'path' => __FILE__,
+ 'name' => 'Nostalgia',
'descriptionmsg' => 'nostalgia-desc',
- 'url' =>
'https://www.mediawiki.org/wiki/Extension:Nostalgia',
+ 'url' => 'https://www.mediawiki.org/wiki/Skin:Nostalgia',
);
-// Include stuff!
-$dir = __DIR__;
-$wgAutoloadClasses['LegacyTemplate'] = "$dir/SkinLegacy.php";
-$wgAutoloadClasses['SkinLegacy'] = "$dir/SkinLegacy.php";
-$wgAutoloadClasses['SkinNostalgia'] = "$dir/Nostalgia_body.php";
+$wgAutoloadClasses['LegacyTemplate'] = __DIR__ . "/SkinLegacy.php";
+$wgAutoloadClasses['SkinLegacy'] = __DIR__ . "/SkinLegacy.php";
+$wgAutoloadClasses['SkinNostalgia'] = __DIR__ . "/Nostalgia_body.php";
$wgMessagesDirs['Nostalgia'] = __DIR__ . '/i18n';
-$wgExtensionMessagesFiles['Nostalgia'] = "$dir/Nostalgia.i18n.php";
+$wgExtensionMessagesFiles['Nostalgia'] = __DIR__ . "/Nostalgia.i18n.php";
$wgValidSkinNames['nostalgia'] = 'Nostalgia';
$wgResourceModules['ext.nostalgia'] = array(
'styles' => array(
--
To view, visit https://gerrit.wikimedia.org/r/137197
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id42c41edd3cab72f6301a1c5d632aa9b4e1acef3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Nostalgia
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
