jenkins-bot has submitted this change and it was merged.
Change subject: Add placeholder for editing header, workaround tooltip issue
......................................................................
Add placeholder for editing header, workaround tooltip issue
Hide the tooltip on click
Change-Id: Iab967f28a94925ea6651f6aebbd493982cafdbf5
---
M Resources.php
M i18n/en.json
M i18n/qqq.json
M modules/new/mw-ui.enhance.js
4 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Resources.php b/Resources.php
index 13468ab..6c49c3c 100644
--- a/Resources.php
+++ b/Resources.php
@@ -59,6 +59,7 @@
),
'messages' => array(
'flow-cancel',
+ 'flow-edit-header-placeholder',
'flow-edit-header-submit',
'flow-edit-title-submit',
'flow-load-more',
diff --git a/i18n/en.json b/i18n/en.json
index d1d11ca..c6932c4 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -131,6 +131,7 @@
"flow-error-process-data": "An error has occurred while processing the
data in your request.",
"flow-error-process-wikitext": "An error has occurred while processing
HTML/wikitext conversion.",
"flow-error-no-index": "Failed to find an index to perform data search.",
+ "flow-edit-header-placeholder": "Describe this Flow board",
"flow-edit-header-submit": "Save header",
"flow-edit-header-submit-overwrite": "Overwrite header",
"flow-summarize-topic-submit": "Summarize",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 2d8297b..120f257 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -133,6 +133,7 @@
"flow-error-process-data": "General error message when failing to
process data.",
"flow-error-process-wikitext": "Error message when failing to process
html/wikitext conversion.",
"flow-error-no-index": "Error message when failing to find an index to
perform data search.",
+ "flow-edit-header-placeholder": "Used as placeholder when editing the
header of a Flow board",
"flow-edit-header-submit": "Used as label for the Submit button.",
"flow-edit-header-submit-overwrite": "Used as label for the Submit
button, when submitting will overwrite a more recent change.",
"flow-summarize-topic-submit": "Used as label for the Summarize
button.",
diff --git a/modules/new/mw-ui.enhance.js b/modules/new/mw-ui.enhance.js
index d85c808..6787b20 100644
--- a/modules/new/mw-ui.enhance.js
+++ b/modules/new/mw-ui.enhance.js
@@ -235,7 +235,7 @@
// Attach the mouseenter and mouseleave handlers on document
$( document )
- .on( 'mouseenter.mw-ui-enhance focus.mw-ui-enhance
click.mw-ui-enhance', '.flow-ui-tooltip-target', onMwUiTooltipFocus )
- .on( 'mouseleave.mw-ui-enhance blur.mw-ui-enhance',
'.flow-ui-tooltip-target', onMwUiTooltipBlur );
+ .on( 'mouseenter.mw-ui-enhance focus.mw-ui-enhance',
'.flow-ui-tooltip-target', onMwUiTooltipFocus )
+ .on( 'mouseleave.mw-ui-enhance blur.mw-ui-enhance
click.mw-ui-enhance', '.flow-ui-tooltip-target', onMwUiTooltipBlur );
} );
}( jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/140854
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab967f28a94925ea6651f6aebbd493982cafdbf5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: frontend-rewrite
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Bsitu <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Spage <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
