JGonera has uploaded a new change for review.
https://gerrit.wikimedia.org/r/141087
Change subject: [WIP] Tweak VE overlay to support mobile context
......................................................................
[WIP] Tweak VE overlay to support mobile context
Change-Id: I358c4aaadbe04f958781fc737dedcd61fb910e9b
---
M javascripts/common/Overlay.js
M javascripts/modules/editor/VisualEditorOverlay.js
M less/common/Overlay.less
3 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/87/141087/1
diff --git a/javascripts/common/Overlay.js b/javascripts/common/Overlay.js
index 3cfc1b8..14e2a32 100644
--- a/javascripts/common/Overlay.js
+++ b/javascripts/common/Overlay.js
@@ -140,7 +140,10 @@
// don't show fixed header on
iPhone, it causes bug 62120
// (also, there is a Done
button on the keyboard anyway)
if ( M.isWideScreen() ) {
- $header.css( 'top',
$window.scrollTop() );
+ // wait for the
keyboard opening animation to finish
+ setTimeout( function() {
+ $header.css(
'top', $window.scrollTop() );
+ }, 300 );
$window.on(
'scroll.fixIosHeader', function() {
$header.css(
'top', $window.scrollTop() ).addClass( 'visible' );
} );
diff --git a/javascripts/modules/editor/VisualEditorOverlay.js
b/javascripts/modules/editor/VisualEditorOverlay.js
index 413c2b5..6b9730d 100644
--- a/javascripts/modules/editor/VisualEditorOverlay.js
+++ b/javascripts/modules/editor/VisualEditorOverlay.js
@@ -147,6 +147,8 @@
this.target.surface.getModel().getDocument().connect(
this, { 'transact': 'onTransact' } );
this.target.surface.$element.addClass( 'content' );
+ // make _fixIosHeader work with mobile context (2nd
line toolbar)
+ this.$( '.ve-ui-mobileContext' ).addClass(
'overlay-header-container visible' );
// for some reason the first time contenteditables are
focused, focus
// event doesn't fire if we don't blur them first
this.$( '[contenteditable]' ).blur();
diff --git a/less/common/Overlay.less b/less/common/Overlay.less
index 3002343..a346b43 100644
--- a/less/common/Overlay.less
+++ b/less/common/Overlay.less
@@ -167,9 +167,12 @@
// needed for _fixIosHeader method to work properly
z-index: 5;
+ // transform transition needed for mobile context in VE
+ .transition-transform( .3s );
+
&.visible {
opacity: 1;
- .transition( opacity .2s );
+ .transition-transform( .3s, opacity .3s; );
}
&.position-fixed {
--
To view, visit https://gerrit.wikimedia.org/r/141087
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I358c4aaadbe04f958781fc737dedcd61fb910e9b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
