Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/141091
Change subject: Provide move left/right quick action buttons for images
......................................................................
Provide move left/right quick action buttons for images
Change-Id: I40ab227ac821d2663ce349ba2baa17e47fe0925c
---
M VisualEditor.php
M modules/ve-mw/i18n/en.json
M modules/ve-mw/i18n/qqq.json
M modules/ve-mw/ui/tools/ve.ui.MWMediaDialogTool.js
4 files changed, 83 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/91/141091/1
diff --git a/VisualEditor.php b/VisualEditor.php
index c20fdd3..2fbc4c2 100644
--- a/VisualEditor.php
+++ b/VisualEditor.php
@@ -791,6 +791,8 @@
'ext.visualEditor.mwimage.core',
),
'messages' => array(
+ 'visualeditor-actionbutton-media-move-left',
+ 'visualeditor-actionbutton-media-move-right',
'visualeditor-dialog-media-alttext-section',
'visualeditor-dialog-media-content-section',
'visualeditor-dialog-media-insert-button',
diff --git a/modules/ve-mw/i18n/en.json b/modules/ve-mw/i18n/en.json
index e29cc27..de65f4c 100644
--- a/modules/ve-mw/i18n/en.json
+++ b/modules/ve-mw/i18n/en.json
@@ -21,6 +21,8 @@
"tooltip-ca-createsource": "Create the source code of this page",
"tooltip-ca-editsource": "Edit the source code of this page",
"tooltip-ca-ve-edit": "Edit this page with VisualEditor",
+ "visualeditor-actionbutton-media-move-left": "Move to the left",
+ "visualeditor-actionbutton-media-move-right": "Move to the right",
"visualeditor-advancedsettings-tool": "Advanced settings",
"visualeditor-annotationbutton-linknode-tooltip": "Simple link",
"visualeditor-beta-appendix": "beta",
diff --git a/modules/ve-mw/i18n/qqq.json b/modules/ve-mw/i18n/qqq.json
index a0271f9..f73ee5e 100644
--- a/modules/ve-mw/i18n/qqq.json
+++ b/modules/ve-mw/i18n/qqq.json
@@ -26,6 +26,8 @@
"tooltip-ca-createsource": "Tooltip of the
{{msg-mw|Visualeditor-ca-createsource}} tab, used if the page does not
exist.\n\nSee also:\n* {{msg-mw|Tooltip-ca-editsource}} - tooltip of the
{{msg-mw|Visualeditor-ca-editsource}} tab, used if the page already exists",
"tooltip-ca-editsource": "Tooltip of the
{{msg-mw|Visualeditor-ca-editsource}} tab, used if the page already
exists.\n\nSee also:\n* {{msg-mw|Tooltip-ca-createsource}} - tooltip of the
{{msg-mw|Visualeditor-ca-createsource}} tab, used if the page does not exist",
"tooltip-ca-ve-edit": "Tooltip of the dedicated VisualEditor \"Edit\"
tab.",
+ "visualeditor-actionbutton-media-move-left": "Label for a button to
move an image to float on the left of the surface",
+ "visualeditor-actionbutton-media-move-right": "Label for a button to
move an image to float on the right of the surface",
"visualeditor-advancedsettings-tool": "Tool for opening the advanced
settings section of the meta dialog.\n{{Identical|Advanced settings}}",
"visualeditor-annotationbutton-linknode-tooltip": "Tooltip text for
link button for auto-numbered, labelless, external links.\n\nSee also:\n*
{{msg-mw|Visualeditor-linknodeinspector-title}}\n{{Related|Visualeditor-annotationbutton}}",
"visualeditor-beta-appendix": "Used in
{{msg-mw|Guidedtour-tour-firsteditve-edit-page-description}}.\n{{Identical|Beta}}",
diff --git a/modules/ve-mw/ui/tools/ve.ui.MWMediaDialogTool.js
b/modules/ve-mw/ui/tools/ve.ui.MWMediaDialogTool.js
index 8f49f2e..d35efbc 100644
--- a/modules/ve-mw/ui/tools/ve.ui.MWMediaDialogTool.js
+++ b/modules/ve-mw/ui/tools/ve.ui.MWMediaDialogTool.js
@@ -50,3 +50,80 @@
ve.ui.MWMediaInsertDialogTool.static.commandName = 'mediaInsert';
ve.ui.MWMediaInsertDialogTool.static.requiresRange = true;
ve.ui.toolFactory.register( ve.ui.MWMediaInsertDialogTool );
+
+/**
+ * MediaWiki UserInterface media move abstract tool.
+ *
+ * @class
+ * @extends ve.ui.DialogTool
+ * @abstract
+ * @constructor
+ * @param {OO.ui.ToolGroup} toolGroup
+ * @param {Object} [config] Configuration options
+ */
+ve.ui.MWBlockMediaMoveTool = function VeUiMWBlockMediaMoveTool( toolGroup,
config ) {
+ ve.ui.DialogTool.call( this, toolGroup, config );
+};
+OO.inheritClass( ve.ui.MWBlockMediaMoveTool, ve.ui.DialogTool );
+ve.ui.MWBlockMediaMoveTool.static.group = 'object';
+ve.ui.MWBlockMediaMoveTool.static.modelClasses = [ ve.dm.MWBlockImageNode ];
+ve.ui.MWBlockMediaMoveTool.static.autoAddToCatchall = false;
+ve.ui.MWBlockMediaMoveTool.static.autoAddToGroup = false;
+
+
+/**
+ * MediaWiki UserInterface media move left tool.
+ *
+ * @class
+ * @extends ve.ui.MWBlockMediaMoveTool
+ * @constructor
+ * @param {OO.ui.ToolGroup} toolGroup
+ * @param {Object} [config] Configuration options
+ */
+ve.ui.MWBlockMediaMoveLeftTool = function VeUiMWBlockMediaMoveLeftTool(
toolGroup, config ) {
+ ve.ui.MWBlockMediaMoveTool.call( this, toolGroup, config );
+};
+OO.inheritClass( ve.ui.MWBlockMediaMoveLeftTool, ve.ui.MWBlockMediaMoveTool );
+ve.ui.MWBlockMediaMoveLeftTool.static.name = 'mediaMoveLeft';
+ve.ui.MWBlockMediaMoveLeftTool.static.icon = 'oo-ui-icon-align-float-left';
+ve.ui.MWBlockMediaMoveLeftTool.static.title =
+ OO.ui.deferMsg( 'visualeditor-actionbutton-media-move-left' );
+ve.ui.MWBlockMediaMoveLeftTool.static.commandName = 'mediaMoveLeft';
+ve.ui.MWBlockMediaMoveLeftTool.static.isCompatibleWith = function ( model ) {
+ return (
+
ve.ui.MWBlockMediaMoveLeftTool.super.static.isCompatibleWith.call( this, model
) &&
+ model.getAttribute( 'align' ) &&
+ model.getAttribute( 'align' ) !== 'none'
+ model.getAttribute( 'align' ) !== 'left'
+ );
+}
+ve.ui.toolFactory.register( ve.ui.MWBlockMediaMoveLeftTool );
+
+
+/**
+ * MediaWiki UserInterface media move right tool.
+ *
+ * @class
+ * @extends ve.ui.MWBlockMediaMoveTool
+ * @constructor
+ * @param {OO.ui.ToolGroup} toolGroup
+ * @param {Object} [config] Configuration options
+ */
+ve.ui.MWBlockMediaMoveRightTool = function VeUiMWBlockMediaMoveRightTool(
toolGroup, config ) {
+ ve.ui.MWBlockMediaMoveTool.call( this, toolGroup, config );
+};
+OO.inheritClass( ve.ui.MWBlockMediaMoveRightTool, ve.ui.MWBlockMediaMoveTool );
+ve.ui.MWBlockMediaMoveRightTool.static.name = 'mediaMoveRight';
+ve.ui.MWBlockMediaMoveRightTool.static.icon = 'oo-ui-icon-align-float-right';
+ve.ui.MWBlockMediaMoveRightTool.static.title =
+ OO.ui.deferMsg( 'visualeditor-actionbutton-media-move-right' );
+ve.ui.MWBlockMediaMoveRightTool.static.commandName = 'mediaMoveRight';
+ve.ui.MWBlockMediaMoveRightTool.static.isCompatibleWith = function ( model ) {
+ return (
+
ve.ui.MWBlockMediaMoveRightTool.super.static.isCompatibleWith.call( this, model
) &&
+ model.getAttribute( 'align' ) &&
+ model.getAttribute( 'align' ) !== 'none'
+ model.getAttribute( 'align' ) !== 'right'
+ );
+}
+ve.ui.toolFactory.register( ve.ui.MWBlockMediaMoveRightTool );
--
To view, visit https://gerrit.wikimedia.org/r/141091
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I40ab227ac821d2663ce349ba2baa17e47fe0925c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
