jenkins-bot has submitted this change and it was merged.
Change subject: Fix some findHooks.php errors
......................................................................
Fix some findHooks.php errors
* Correct typo in docs/hooks.txt.
* Add a few directories.
Left unfixed is "Undocumented: Special{$this->getName()}BeforeFormDisplay",
which will be addressed separately.
Change-Id: I4fda8960642c23500bd20e0b89c1d1327456313b
---
M docs/hooks.txt
M maintenance/findHooks.php
2 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/docs/hooks.txt b/docs/hooks.txt
index 4c2fd89..80ac174 100644
--- a/docs/hooks.txt
+++ b/docs/hooks.txt
@@ -1041,11 +1041,11 @@
contents of $error to be echoed at the top of the edit form as wikitext.
Return true without altering $error to allow the edit to proceed.
-'EditPage::showReadOnlyForm:initial: similar to EditPage::showEditForm:initial
-but for the readonly 'view source' variant of the edit form.
+'EditPage::showReadOnlyForm:initial': similar to EditPage::showEditForm:initial
+but for the read-only 'view source' variant of the edit form.
$editor: EditPage instance (object)
&$out: an OutputPage instance to write to
-return value is ignored (should alway return true)
+return value is ignored (should always return true)
'EditPage::showStandardInputs:options': allows injection of form fields into
the editOptions area
diff --git a/maintenance/findHooks.php b/maintenance/findHooks.php
index 86c01f4..043aed2 100644
--- a/maintenance/findHooks.php
+++ b/maintenance/findHooks.php
@@ -63,6 +63,8 @@
$documented = $this->getHooksFromDoc( $IP . '/docs/hooks.txt' );
$potential = array();
$bad = array();
+
+ // TODO: Don't hardcode the list of directories
$pathinc = array(
$IP . '/',
$IP . '/includes/',
@@ -99,6 +101,7 @@
$IP . '/includes/specialpage/',
$IP . '/includes/specials/',
$IP . '/includes/upload/',
+ $IP . '/includes/utils/',
$IP . '/languages/',
$IP . '/maintenance/',
$IP . '/maintenance/language/',
@@ -106,6 +109,8 @@
$IP . '/tests/parser/',
$IP . '/tests/phpunit/suites/',
$IP . '/skins/',
+ $IP . '/skins/monobook/',
+ $IP . '/skins/Vector/',
);
foreach ( $pathinc as $dir ) {
--
To view, visit https://gerrit.wikimedia.org/r/141096
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4fda8960642c23500bd20e0b89c1d1327456313b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: PleaseStand <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
