jenkins-bot has submitted this change and it was merged.

Change subject: re-order keys: put 'en', 'qqq' on top
......................................................................


re-order keys: put 'en', 'qqq' on top

Change-Id: I17c17ab64bc8fdab7c0859e66899e17cbf802b84
---
M scripts/maintenance/make_i18n_dict.py
1 file changed, 14 insertions(+), 6 deletions(-)

Approvals:
  John Vandenberg: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/scripts/maintenance/make_i18n_dict.py 
b/scripts/maintenance/make_i18n_dict.py
index 452ba61..3292d11 100644
--- a/scripts/maintenance/make_i18n_dict.py
+++ b/scripts/maintenance/make_i18n_dict.py
@@ -43,7 +43,13 @@
 
     def print_all(self):
         keys = self.dict.keys()
+        keys.remove('qqq')
         keys.sort()
+        keys.insert(0, 'qqq')
+        if 'en' in keys:
+            keys.remove('en')
+            keys.insert(0, 'en')
+
         print "# -*- coding: utf-8 -*-"
         print "msg = {"
         for code in keys:
@@ -58,20 +64,22 @@
 
     def read(self, item):
         msg = getattr(self.script, item)
-        self.keys = msg.keys()
-        self.keys.append('qqq')
-        self.keys.sort()
-        for code in self.keys:
+        keys = msg.keys()
+        keys.append('qqq')
+        for code in keys:
             label = "%s-%s" % (self.scriptname, item)
             if code == 'qqq':
                 if code not in self.dict:
                     self.dict[code] = {}
-                self.dict[code][label] = \
-                    u'Edit summary for %s report' % self.scriptname
+                self.dict[code][label] = (
+                    u'Edit summary for message %s of %s report'
+                    % (self.scriptname, item))
             elif code != 'commons':
                 if code not in self.dict:
                     self.dict[code] = {}
                 self.dict[code][label] = msg[code]
+        if 'en' not in keys:
+            print 'WARNING: "en" key missing for message %s' % item
 
     def run(self):
         for msg in self.messages:

-- 
To view, visit https://gerrit.wikimedia.org/r/141290
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I17c17ab64bc8fdab7c0859e66899e17cbf802b84
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <i...@gno.de>
Gerrit-Reviewer: John Vandenberg <jay...@gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhall...@arctus.nl>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to