jenkins-bot has submitted this change and it was merged.
Change subject: php codesniffer suggestions
......................................................................
php codesniffer suggestions
* Limit lines to 100 chars
* Use 'elseif' instead of 'else if'
Change-Id: Ic18ce2968fd50c3f344655a93926e0ba9f6eac16
---
M VectorBeta.hooks.php
M VectorBeta.php
2 files changed, 8 insertions(+), 6 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/VectorBeta.hooks.php b/VectorBeta.hooks.php
index f1c1a72..08d652c 100644
--- a/VectorBeta.hooks.php
+++ b/VectorBeta.hooks.php
@@ -34,7 +34,7 @@
$className .= 'mw-menu-item mw-icon mw-' . $key .
'-icon';
if ( strpos( $item['id'], 'ca-nstab' ) === 0 ) {
$className .= ' mw-page-icon';
- } else if ( $item['id'] = 'ca-talk' ) {
+ } elseif ( $item['id'] = 'ca-talk' ) {
$className .= ' mw-talk-icon';
}
$htmlMenu .= Html::openElement( 'li', array(
@@ -59,7 +59,8 @@
*/
static function isFixedHeaderEnabled( $user ) {
global $wgVectorBetaWinter;
- return $wgVectorBetaWinter && BetaFeatures::isFeatureEnabled(
$user, 'betafeatures-vector-fixedheader' );
+ return $wgVectorBetaWinter &&
+ BetaFeatures::isFeatureEnabled( $user,
'betafeatures-vector-fixedheader' );
}
/**
@@ -81,7 +82,7 @@
if ( !class_exists( 'BetaFeatures' ) ) {
wfDebugLog( 'VectorBeta', 'The BetaFeatures extension
is not installed' );
return true;
- } else if ( self::isFixedHeaderEnabled( $skin->getUser() ) ) {
+ } elseif ( self::isFixedHeaderEnabled( $skin->getUser() ) ) {
$data = $tpl->data;
$skin = $data['skin'];
$nav = $data['content_navigation'];
@@ -152,7 +153,7 @@
// Make ajax work
$pageActions['watch']['class'] .= ' mw-watchlink';
unset( $actions['watch'] );
- } else if ( isset( $actions['unwatch'] ) ){
+ } elseif ( isset( $actions['unwatch'] ) ){
$pageActions['unwatch'] = $actions['unwatch'];
// Make ajax work
$pageActions['unwatch']['class'] .= ' mw-watchlink';
@@ -222,7 +223,7 @@
if ( isset( $views['edit'] ) ) {
$edit = $views['edit'];
- } else if ( isset( $views['viewsource'] ) ) {
+ } elseif ( isset( $views['viewsource'] ) ) {
$edit = $views['viewsource'];
} else {
$edit = false;
diff --git a/VectorBeta.php b/VectorBeta.php
index b0b2e96..ee8deee 100644
--- a/VectorBeta.php
+++ b/VectorBeta.php
@@ -125,7 +125,8 @@
),
) );
-$wgHooks['SkinTemplateOutputPageBeforeExec'][] =
'VectorBetaHooks::getSkinTemplateOutputPageBeforeExec';
+$wgHooks['SkinTemplateOutputPageBeforeExec'][] =
+ 'VectorBetaHooks::getSkinTemplateOutputPageBeforeExec';
$wgHooks['GetBetaFeaturePreferences'][] = 'VectorBetaHooks::getPreferences';
$wgHooks['BeforePageDisplay'][] = 'VectorBetaHooks::onBeforePageDisplay';
$wgHooks['SkinVectorStyleModules'][] =
'VectorBetaHooks::skinVectorStyleModules';
--
To view, visit https://gerrit.wikimedia.org/r/131261
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic18ce2968fd50c3f344655a93926e0ba9f6eac16
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VectorBeta
Gerrit-Branch: master
Gerrit-Owner: KartikMistry <kartik.mis...@gmail.com>
Gerrit-Reviewer: Amire80 <amir.ahar...@mail.huji.ac.il>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jorm <bhar...@wikimedia.org>
Gerrit-Reviewer: Kaldari <rkald...@wikimedia.org>
Gerrit-Reviewer: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
