jenkins-bot has submitted this change and it was merged. Change subject: mediawiki.searchSuggest: Enable result caching ......................................................................
mediawiki.searchSuggest: Enable result caching Also remove redundant 'delay' option, this is 120 by default. Bug: 65581 Change-Id: I38d5fe0cb9bb883d398295a97e30c29d68211e31 --- M resources/src/mediawiki/mediawiki.searchSuggest.js 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Bartosz Dziewoński: Looks good to me, approved Florianschmidtwelzow: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/resources/src/mediawiki/mediawiki.searchSuggest.js b/resources/src/mediawiki/mediawiki.searchSuggest.js index 282cf6f..a314dcb 100644 --- a/resources/src/mediawiki/mediawiki.searchSuggest.js +++ b/resources/src/mediawiki/mediawiki.searchSuggest.js @@ -121,9 +121,8 @@ ]; $( searchboxesSelectors.join( ', ' ) ) .suggestions( { - fetch: function ( query ) { - var $textbox = this, - node = this[0]; + fetch: function ( query, response ) { + var node = this[0]; api = api || new mw.Api(); @@ -133,7 +132,7 @@ namespace: 0, suggest: '' } ).done( function ( data ) { - $textbox.suggestions( 'suggestions', data[1] ); + response( data[ 1 ] ); } ) ); }, cancel: function () { @@ -152,7 +151,7 @@ return true; } }, - delay: 120, + cache: true, highlightInput: true } ) .bind( 'paste cut drop', function () { -- To view, visit https://gerrit.wikimedia.org/r/134542 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38d5fe0cb9bb883d398295a97e30c29d68211e31 Gerrit-PatchSet: 11 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Alex Monk <kren...@wikimedia.org> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.wel...@t-online.de> Gerrit-Reviewer: Fomafix Gerrit-Reviewer: Hoo man <h...@online.de> Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits