jenkins-bot has submitted this change and it was merged.

Change subject: SpecialCite: fix escaping of message
......................................................................


SpecialCite: fix escaping of message

Linker::link takes raw HTML, so use ->escaped().

Also use $skin->msg() instead of wfMessage.

Change-Id: I56c0791d31897793b0e8cd8ac18ea337a96d1ff0
---
M SpecialCite.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Hoo man: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SpecialCite.php b/SpecialCite.php
index 60fd967..3dc8975 100644
--- a/SpecialCite.php
+++ b/SpecialCite.php
@@ -79,7 +79,7 @@
                        array( 'id' => 't-cite' ),
                        Linker::link(
                                SpecialPage::getTitleFor( 'Cite' ),
-                               wfMessage( 'cite_article_link' )->text(), // 
@todo Should be escaped()?
+                               $skin->msg( 'cite_article_link' )->escaped(),
                                # Used message keys: 'tooltip-cite-article', 
'accesskey-cite-article'
                                Linker::tooltipAndAccessKeyAttribs( 
'cite-article' ),
                                $skin->data['nav_urls']['cite']['args']

-- 
To view, visit https://gerrit.wikimedia.org/r/141372
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I56c0791d31897793b0e8cd8ac18ea337a96d1ff0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to