Cicalese has uploaded a new change for review.
https://gerrit.wikimedia.org/r/141309
Change subject: mproved renderingImprove
......................................................................
mproved renderingImprove
Change-Id: Ife7530525f39405cc6499f1ab12e3d215c3ea4f9
---
M SemanticRating.class.php
M SemanticRating.php
2 files changed, 4 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticRating
refs/changes/09/141309/1
diff --git a/SemanticRating.class.php b/SemanticRating.class.php
index 40e4a63..eaf4fb4 100644
--- a/SemanticRating.class.php
+++ b/SemanticRating.class.php
@@ -26,9 +26,7 @@
public function renderRating($input, $imagepath) {
- $output =
- Html::openElement('table', array('style' =>
'display:inline;')) .
- Html::openElement('td');
+ $output = Html::openElement('span');
if ($input < 0) {
$input = 0;
@@ -57,8 +55,7 @@
}
$output .=
- Html::closeElement('td') .
- Html::closeElement('table');
+ Html::closeElement('span');
return $output;
}
diff --git a/SemanticRating.php b/SemanticRating.php
index 8e0089d..37189d2 100644
--- a/SemanticRating.php
+++ b/SemanticRating.php
@@ -39,7 +39,7 @@
$wgExtensionCredits['semantic'][] = array (
'name' => 'SemanticRating',
- 'version' => '1.1.0',
+ 'version' => '1.2',
'author' => array(
'[https://www.mediawiki.org/wiki/User:Cindy.cicalese Cindy
Cicalese]'
),
@@ -84,8 +84,7 @@
global $SemanticRating_ImagePath;
$instance = new SemanticRating;
$output = $instance->renderRating($input, $SemanticRating_ImagePath);
- return array($parser->insertStripItem( $output, $parser->mStripState ),
- 'noparse' => false);
+ return $output;
}
function editRating($cur_value, $input_name, $is_mandatory, $is_disabled,
--
To view, visit https://gerrit.wikimedia.org/r/141309
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife7530525f39405cc6499f1ab12e3d215c3ea4f9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticRating
Gerrit-Branch: master
Gerrit-Owner: Cicalese <cical...@mitre.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
