Krinkle has uploaded a new change for review. Change subject: Fix up various issues leading to bug 40780. ......................................................................
Fix up various issues leading to bug 40780. * jquery.autoEllipsis didn't return 'this', which means whenever it was used in a chain, it would return undefined. So in mediawiki.searchSuggest append( ... autoEllipsis() ) would apply it to a detached node that stays detached because it isn't passed to append. * Remove redundant passing of this in jQuery context to $(). On jQuery.prototype, 'this' is obviously a jQuery object. In jquery.highlightText, which is called from jquery.autoEllipsis. * Remove redundant .empty() call before calling .text( .. ), .text() replaces all content and naturally is forced to empty the element first. * Merge use of $el and $container in jquery.autoEllipsis.js. They were both pointing to the same object, having two names was only confusing. * Spaces. Change-Id: I4649ec0c89d38c4d79d1dceec28227902cd48d32 --- M resources/jquery/jquery.autoEllipsis.js M resources/jquery/jquery.highlightText.js M resources/mediawiki/mediawiki.searchSuggest.js 3 files changed, 19 insertions(+), 21 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/86/27386/1 -- To view, visit https://gerrit.wikimedia.org/r/27386 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4649ec0c89d38c4d79d1dceec28227902cd48d32 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Krinkle <ttij...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
