Ori.livneh has submitted this change and it was merged.
Change subject: [HAT] Load mod_version on application servers
......................................................................
[HAT] Load mod_version on application servers
'HAT' stands for 'HHVM, Apache 2.4, and Trusty' (in the spirit of 'LAMP').
I'm going to start using this tag in HAT-migration commits as a useful flag for
reviewers.
This particular patch ensures mod_version is loaded on all application servers.
We already settled on this approach in I5abf01810, which ensured mod_version is
enabled by default via the apache module. But the application servers have a
custom apache2.conf that does not recurse into /etc/apache2/mods-enabled/*, so
it is necessary to do this here for now.
We need mod_version so that we can introduce <IfVersion >= 2.4> / <IfVersion <=
2.2>
configuration guards and thus make our Apache configs compatible with both 2.4
and 2.2
mod_version is part of apache2.2-bin and thus available on all application
servers. You can verify the first claim by running:
dpkg -L apache2.2-bin | grep mod_version
You can verify that the module is present on all app servers by running the
following command on palladium:
salt 'mw*' cmd.run 'test -f /usr/lib/apache2/modules/mod_version.so'\
' && echo OK || echo MOD_VERSION MISSING!'
Change-Id: I639d4d6dc424fc750325aee7c4a104eba48c1821
---
M modules/mediawiki/templates/apache/apache2.conf.erb
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Ori.livneh: Verified; Looks good to me, approved
diff --git a/modules/mediawiki/templates/apache/apache2.conf.erb
b/modules/mediawiki/templates/apache/apache2.conf.erb
index 78aa63b..2ad7403 100644
--- a/modules/mediawiki/templates/apache/apache2.conf.erb
+++ b/modules/mediawiki/templates/apache/apache2.conf.erb
@@ -11,6 +11,7 @@
LoadModule alias_module /usr/lib/apache2/modules/mod_alias.so
LoadModule mime_module /usr/lib/apache2/modules/mod_mime.so
LoadModule status_module /usr/lib/apache2/modules/mod_status.so
+LoadModule version_module /usr/lib/apache2/modules/mod_version.so
ServerRoot "/etc/apache2"
#LockFile /usr/local/apache/logs/httpd.lock
--
To view, visit https://gerrit.wikimedia.org/r/141059
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I639d4d6dc424fc750325aee7c4a104eba48c1821
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Tim Starling <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
