jenkins-bot has submitted this change and it was merged.
Change subject: Revert "Accessibility: Restore element focus when a window
closes"
......................................................................
Revert "Accessibility: Restore element focus when a window closes"
This break VE dialogs as we already restore selection to the correct place with
fragment.select(). Focus just resets the selection to 0.
This reverts commit 0447150c57c76da7b739c95b4706eaf515119a7c.
Bug: 66855
Change-Id: I6d17eeff8473d47a1e5a2cd53e73de734c45ff2c
---
M src/Window.js
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Alex Monk: Looks good to me, but someone else must approve
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/Window.js b/src/Window.js
index cbd6b40..6b3dd26 100644
--- a/src/Window.js
+++ b/src/Window.js
@@ -385,8 +385,6 @@
// Open the window
this.opening = $.Deferred();
- // So we can restore focus on closing
- this.$prevFocus = $( document.activeElement );
this.$ariaHidden = $( 'body' ).children().not(
this.$element.parentsUntil( 'body' ).last() )
.attr( 'aria-hidden', '' );
@@ -453,11 +451,6 @@
this.opened.resolve();
}
this.$element.hide();
- // Restore focus to whatever was focused before opening
- if ( this.$prevFocus ) {
- this.$prevFocus.focus();
- this.$prevFocus = undefined;
- }
if ( this.$ariaHidden ) {
this.$ariaHidden.removeAttr( 'aria-hidden' );
this.$ariaHidden = undefined;
--
To view, visit https://gerrit.wikimedia.org/r/141940
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d17eeff8473d47a1e5a2cd53e73de734c45ff2c
Gerrit-PatchSet: 3
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
