[MediaWiki-commits] [Gerrit] Remove unused parameters - change (mediawiki...Wikibase)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Remove unused parameters
......................................................................


Remove unused parameters

Change-Id: I89baba5fc281cb002ea8df0cd36f3960ab3a6b03
---
M repo/includes/View/SiteLinksView.php
1 file changed, 7 insertions(+), 10 deletions(-)

Approvals:
  Aude: Looks good to me, approved
  WikidataJenkins: Verified
  jenkins-bot: Verified



diff --git a/repo/includes/View/SiteLinksView.php 
b/repo/includes/View/SiteLinksView.php
index 24a4782..c5d143f 100644
--- a/repo/includes/View/SiteLinksView.php
+++ b/repo/includes/View/SiteLinksView.php
@@ -33,10 +33,12 @@
         * @return string
         */
        public function getHtml( array $siteLinks, EntityId $entityId, array 
$groups, $editable ) {
+               // FIXME: editable is completely unused
+               
                $html = '';
 
                foreach ( $groups as $group ) {
-                       $html .= $this->getHtmlForSiteLinkGroup( $siteLinks, 
$entityId, $group, $editable );
+                       $html .= $this->getHtmlForSiteLinkGroup( $siteLinks, 
$entityId, $group );
                }
 
                return $html;
@@ -48,20 +50,16 @@
         * @param SiteLink[] $siteLinks the site links to render
         * @param EntityId $entityId The id of the entity
         * @param string $group a site group ID
-        * @param bool $editable whether editing is allowed (enabled edit links)
         *
         * @return string
         */
-       private function getHtmlForSiteLinkGroup( array $siteLinks, EntityId 
$entityId, $group, $editable = true ) {
-
-               // FIXME: editable is completely unused
-
+       private function getHtmlForSiteLinkGroup( array $siteLinks, EntityId 
$entityId, $group ) {
                $specialGroups = 
WikibaseRepo::getDefaultInstance()->getSettings()->getSetting( 
"specialSiteLinkGroups" );
                $isSpecialGroup = in_array( $group, $specialGroups );
 
                // @todo inject into constructor
                $sites = $this->siteStore->getSites()->getGroup( $group );
-               $siteLinksForTable = $this->getSiteLinksForTable( $sites, 
$group, $siteLinks );
+               $siteLinksForTable = $this->getSiteLinksForTable( $sites, 
$siteLinks );
 
                $html = $thead = $tbody = $tfoot = '';
 
@@ -97,12 +95,11 @@
 
        /**
         * @param SiteList $sites
-        * @param string $group
         * @param SiteLink[] $itemSiteLinks
         *
         * @return array[]
         */
-       private function getSiteLinksForTable( SiteList $sites, $group, array 
$itemSiteLinks ) {
+       private function getSiteLinksForTable( SiteList $sites, array 
$itemSiteLinks ) {
                $siteLinksForTable = array(); // site links of the currently 
handled site group
 
                foreach( $itemSiteLinks as $siteLink ) {
@@ -244,7 +241,7 @@
         * @param SiteLink $siteLink
         * @param EntityId $entityId The id of the entity
         * @param string $alternatingClass
-        * 
+        *
         * @return string
         */
        private function getHtmlForUnknownSiteLink( $siteLink, $entityId, 
$alternatingClass ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/142275
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I89baba5fc281cb002ea8df0cd36f3960ab3a6b03
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits