Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/142486

Change subject: Set height:100% on blur filter to improve Safari fullscreen 
transition
......................................................................

Set height:100% on blur filter to improve Safari fullscreen transition

It's like black magic, except we use an SVG instead of goat blood!

Bug: 67119
Change-Id: I729c2f927122a5e41be3e9c4e52216ea812c8314
---
M resources/mmv/mmv.lightboxinterface.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer 
refs/changes/86/142486/1

diff --git a/resources/mmv/mmv.lightboxinterface.js 
b/resources/mmv/mmv.lightboxinterface.js
index ddcfd5e..2a77c63 100644
--- a/resources/mmv/mmv.lightboxinterface.js
+++ b/resources/mmv/mmv.lightboxinterface.js
@@ -50,7 +50,8 @@
         */
        LIP.init = function () {
                // SVG filter, needed to achieve blur in Firefox
-               this.$filter = $( '<svg><filter 
id="gaussian-blur"><fegaussianblur stdDeviation="3"></filter></svg>' );
+               // allegedly, height: 100% does something useful on Safari - 
see bug 67119
+               this.$filter = $( '<svg style="height: 100%"><filter 
id="gaussian-blur"><fegaussianblur stdDeviation="3"></filter></svg>' );
 
                this.$wrapper = $( '<div>' )
                        .addClass( 'mw-mmv-wrapper' );

-- 
To view, visit https://gerrit.wikimedia.org/r/142486
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I729c2f927122a5e41be3e9c4e52216ea812c8314
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to