jenkins-bot has submitted this change and it was merged. Change subject: Code cleanup: Fix JSCS errors ......................................................................
Code cleanup: Fix JSCS errors Reported by jscs with wikimedia preset Change-Id: Ia29a793cc5c4ba7bad8844a7df6ba005198829f5 --- M modules/translation/ext.cx.translation.js 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Divec: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/translation/ext.cx.translation.js b/modules/translation/ext.cx.translation.js index fbf43a1..c79d303 100644 --- a/modules/translation/ext.cx.translation.js +++ b/modules/translation/ext.cx.translation.js @@ -119,7 +119,7 @@ $section.replaceWith( $( '#' + sourceId ) .clone() .attr( { - 'id': 'cx' + sourceId, + id: 'cx' + sourceId, 'data-source': sourceId } ) ); @@ -299,19 +299,19 @@ .hover( sectionMouseEnterHandler, sectionMouseLeaveHandler ) .on( 'click', sectionClick ) .attr( { - 'id': 'cx' + sourceSectionId, + id: 'cx' + sourceSectionId, 'data-source': sourceSectionId } ) .css( { // Copy a bunch of position related attribute values 'min-height': $sourceSection.outerHeight(), - 'width': $sourceSection.width(), + width: $sourceSection.width(), 'margin-top': $sourceSection.css( 'margin-top' ), 'margin-bottom': $sourceSection.css( 'margin-bottom' ), - 'display': $sourceSection.css( 'display' ), - 'float': $sourceSection.css( 'float' ), - 'clear': $sourceSection.css( 'clear' ), - 'position': $sourceSection.css( 'position' ) + display: $sourceSection.css( 'display' ), + float: $sourceSection.css( 'float' ), + clear: $sourceSection.css( 'clear' ), + position: $sourceSection.css( 'position' ) } ) .html( mw.msg( 'cx-translation-add-translation' ) ); } -- To view, visit https://gerrit.wikimedia.org/r/142497 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia29a793cc5c4ba7bad8844a7df6ba005198829f5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com> Gerrit-Reviewer: Divec <da...@sheetmusic.org.uk> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits