Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142612
Change subject: Replace deprecated Title::escapeFullURL calls
......................................................................
Replace deprecated Title::escapeFullURL calls
Change-Id: I48a2dcfbce1780639cfd1155352253244fec40c0
---
M SemanticTasks.classes.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticTasks
refs/changes/12/142612/1
diff --git a/SemanticTasks.classes.php b/SemanticTasks.classes.php
index 9558d46..cebab45 100644
--- a/SemanticTasks.classes.php
+++ b/SemanticTasks.classes.php
@@ -251,7 +251,7 @@
if ( !empty( $assignees ) ) {
$title_text = $title->getFullText();
$from = new MailAddress( $user->getEmail(),
$user->getName() );
- $link = $title->escapeFullURL();
+ $link = htmlspecialchars( $title->getFullURL() );
if ( $status == NEWTASK ) {
$subject = '[' . $wgSitename . '] ' . wfMsg(
'semantictasks-newtask' ) . ' ' . $title_text;
@@ -381,7 +381,7 @@
$task_name = $row[0]->getNextObject()->getTitle();
$subject = '[' . $wgSitename . '] ' . wfMsg(
'semantictasks-reminder' ) . $task_name;
// The following doesn't work, maybe because we use a
cron job.
- // $link = $task_name->escapeFullURL();
+ // $link = $task_name->getFullURL();
// So let's do it manually
$link = $wiki_url . $task_name->getPartialURL();
--
To view, visit https://gerrit.wikimedia.org/r/142612
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I48a2dcfbce1780639cfd1155352253244fec40c0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticTasks
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
