Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142873
Change subject: Fix return doc for UploadBase::isAllowed
......................................................................
Fix return doc for UploadBase::isAllowed
Method can return bool or string
Change-Id: Ib290843ce97926bfc529d510b1898f35c7e3f6c6
---
M includes/specials/SpecialUpload.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/73/142873/1
diff --git a/includes/specials/SpecialUpload.php
b/includes/specials/SpecialUpload.php
index 01c0aaf..1d976e2 100644
--- a/includes/specials/SpecialUpload.php
+++ b/includes/specials/SpecialUpload.php
@@ -827,7 +827,7 @@
}
$canUploadByUrl = UploadFromUrl::isEnabled()
- && UploadFromUrl::isAllowed( $this->getUser() )
+ && UploadFromUrl::isAllowed( $this->getUser() ) === true
&& $wgCopyUploadsFromSpecialUpload;
$radio = $canUploadByUrl;
$selectedSourceType = strtolower( $this->getRequest()->getText(
'wpSourceType', 'File' ) );
--
To view, visit https://gerrit.wikimedia.org/r/142873
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib290843ce97926bfc529d510b1898f35c7e3f6c6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
